From owner-svn-src-stable-8@FreeBSD.ORG Wed Aug 18 20:23:56 2010 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E28A106577E; Wed, 18 Aug 2010 20:23:56 +0000 (UTC) (envelope-from gavin@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 3534B8FC1C; Wed, 18 Aug 2010 20:23:56 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o7IKNuAs079433; Wed, 18 Aug 2010 20:23:56 GMT (envelope-from gavin@svn.freebsd.org) Received: (from gavin@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o7IKNuxn079431; Wed, 18 Aug 2010 20:23:56 GMT (envelope-from gavin@svn.freebsd.org) Message-Id: <201008182023.o7IKNuxn079431@svn.freebsd.org> From: Gavin Atkinson Date: Wed, 18 Aug 2010 20:23:56 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r211466 - stable/8/sys/dev/sound/pci/hda X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2010 20:23:56 -0000 Author: gavin Date: Wed Aug 18 20:23:55 2010 New Revision: 211466 URL: http://svn.freebsd.org/changeset/base/211466 Log: Merge 210839 from head: Do not free sc if attach failed, as it was allocated by the bus infrastructure, not us. This appears to be a leftover from an older version of the driver. Submitted by: avg Tested by: Anton Shterenlikht Modified: stable/8/sys/dev/sound/pci/hda/hdac.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/amd64/include/xen/ (props changed) stable/8/sys/cam/ (props changed) stable/8/sys/cddl/contrib/opensolaris/ (props changed) stable/8/sys/contrib/dev/acpica/ (props changed) stable/8/sys/contrib/pf/ (props changed) stable/8/sys/dev/xen/xenpci/ (props changed) Modified: stable/8/sys/dev/sound/pci/hda/hdac.c ============================================================================== --- stable/8/sys/dev/sound/pci/hda/hdac.c Wed Aug 18 20:23:47 2010 (r211465) +++ stable/8/sys/dev/sound/pci/hda/hdac.c Wed Aug 18 20:23:55 2010 (r211466) @@ -4304,7 +4304,6 @@ hdac_attach_fail: hdac_dma_free(sc, &sc->corb_dma); hdac_mem_free(sc); snd_mtxfree(sc->lock); - free(sc, M_DEVBUF); return (ENXIO); }