From nobody Sun Jan 25 15:56:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dzbrn72Fmz6PjVB for ; Sun, 25 Jan 2026 15:56:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dzbrn419Tz47yJ for ; Sun, 25 Jan 2026 15:56:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769356617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rPKRHoFpCt1droJ8iMW3PmyTRiRrDGzzcG4GLFlKZmo=; b=B2VEgpji0BYpQZ+AkoXKsiMOhtzBLEvYeLoVqkOg831ypZ20W/6HnmLqdqF/CHzqQE4+Gn OcNVb0YLCH2Efp1LXOAT0KUlpFiRFoyT5uI/D270SWvmV7cT9p/O4GoVcSWPqwQQp0jgUG HpRVnsS7+ejPrGNQ4dLEHfjDPs13B5D7/gCU2gmdgQ37jt82zWLIyBC6PZbgD5XzlbSGd1 zwokio37CUyyoFXsr7cm8mEJE9M2FwU0q0wCnta6foyB9CrRoxMtiHj0+6YZ9nm0XQFJkG h18hI1GnbkPna4gt9bCUdl6MnocC+PrvsfFMB7Ohc1ozVLWLH27nmTxQorbtKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769356617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rPKRHoFpCt1droJ8iMW3PmyTRiRrDGzzcG4GLFlKZmo=; b=dMuaGwQSI+iCaVY7YTKK2D3rpKiWxqfvxjS9mWQs54asKyYurSa4IsI53FigFqXi/+ODD7 zXK31FADmVxHaXIUKmas0mM7oG7uV/I1qeElp/fX4E1uPcfkcECrxVne1az0sJBJgy7UbA 2gg+YdKe+ebjGrpMj1q/xXGfjFCo4MRzGMPf+AR4eB0iOg3iPEQ+o4gZbMXpjYY4mxkXji foWURRH0qMpcCQVAV2EJCEioPCc4HqgA3WvkO3OxWGIhjo0LOyQTrwJ2zoLwWlzMwTg8A5 WZTKN36r2usN38xui5h7RNJGFt7o2YoukvG6qdpTs+zppQogaECXJMkog/I2Vw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769356617; a=rsa-sha256; cv=none; b=oAaOUbHh7RjXQG+ImyGMlTdN80iOxSLnylwBcleiMwg1NOH/c9H6RwfRDJehe1PW9EICuy yxomc0QHUoLFPwC4tyeN0uBqdUkotnNmenC9+hBtxGP731Cw9p1LaiRPmg12Jfei9mtf/j lgQM6vlIIKOfqNL/U8GGUI+FeDLGxV0MImIL4v3WREJEvkcfltCoQ3220uNalqC73F1iFY YuW19g9WqmAMZNz6HMwMEuumNJZuEBZORPElqQQvVARH3eWxZ34yMWS6S7J/LD7HmolO5Z RIFRqlaAd+p9bk/JuOPC6IzePyySnH4Q0jY8kGYukp751XsgS523OaVH6NeiWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dzbrn3YRdzhxM for ; Sun, 25 Jan 2026 15:56:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3407d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 25 Jan 2026 15:56:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 09984871d8ca - main - procdesc: postpone freeing the zombie' pid until procdesc is freed List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 09984871d8caff9263b955a94bb9fb5354af1b4c Auto-Submitted: auto-generated Date: Sun, 25 Jan 2026 15:56:57 +0000 Message-Id: <69763d49.3407d.60419524@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=09984871d8caff9263b955a94bb9fb5354af1b4c commit 09984871d8caff9263b955a94bb9fb5354af1b4c Author: Konstantin Belousov AuthorDate: 2026-01-15 05:28:31 +0000 Commit: Konstantin Belousov CommitDate: 2026-01-25 15:53:54 +0000 procdesc: postpone freeing the zombie' pid until procdesc is freed Requested by: asomers Reviewed by: asomers, markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D54592 --- sys/kern/kern_exit.c | 4 ++-- sys/kern/sys_procdesc.c | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/sys/kern/kern_exit.c b/sys/kern/kern_exit.c index 53225bcfd425..beb29e890bd7 100644 --- a/sys/kern/kern_exit.c +++ b/sys/kern/kern_exit.c @@ -979,10 +979,10 @@ proc_reap(struct thread *td, struct proc *p, int *status, int options) leavepgrp(p); if (p->p_procdesc != NULL) procdesc_reap(p); + else + proc_id_clear(PROC_ID_PID, p->p_pid); sx_xunlock(&proctree_lock); - proc_id_clear(PROC_ID_PID, p->p_pid); - PROC_LOCK(p); knlist_detach(p->p_klist); p->p_klist = NULL; diff --git a/sys/kern/sys_procdesc.c b/sys/kern/sys_procdesc.c index c5db21544b0f..4f5b08003735 100644 --- a/sys/kern/sys_procdesc.c +++ b/sys/kern/sys_procdesc.c @@ -270,6 +270,9 @@ procdesc_free(struct procdesc *pd) KASSERT((pd->pd_flags & PDF_CLOSED), ("procdesc_free: !PDF_CLOSED")); + if (pd->pd_pid != -1) + proc_id_clear(PROC_ID_PID, pd->pd_pid); + knlist_destroy(&pd->pd_selinfo.si_note); PROCDESC_LOCK_DESTROY(pd); free(pd, M_PROCDESC); @@ -389,6 +392,7 @@ procdesc_close(struct file *fp, struct thread *td) */ pd->pd_proc = NULL; p->p_procdesc = NULL; + pd->pd_pid = -1; procdesc_free(pd); /*