From owner-freebsd-net  Fri Dec 21 10:44:22 2001
Delivered-To: freebsd-net@freebsd.org
Received: from elvis.mu.org (elvis.mu.org [216.33.66.196])
	by hub.freebsd.org (Postfix) with ESMTP
	id 50F1937B417; Fri, 21 Dec 2001 10:44:17 -0800 (PST)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id E85CE81E0F; Fri, 21 Dec 2001 12:44:16 -0600 (CST)
Date: Fri, 21 Dec 2001 12:44:16 -0600
From: Alfred Perlstein <alfred@FreeBSD.org>
To: Bruce Evans <bde@zeta.org.au>
Cc: wollman@FreeBSD.org, net@FreeBSD.org, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: fifo fix (Re: cvs commit: src/sys/fs/fifofs fifo_vnops.c)
Message-ID: <20011221124416.T48837@elvis.mu.org>
References: <20011218111531.A59831@elvis.mu.org> <20011222011614.C4869-100000@gamplex.bde.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20011222011614.C4869-100000@gamplex.bde.org>; from bde@zeta.org.au on Sat, Dec 22, 2001 at 01:27:32AM +1100
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org

* Bruce Evans <bde@zeta.org.au> [011221 08:27] wrote:
> 
> I think it should be more like:
> 
> 	if (ap->a_events & POLLIN)
> 		ap->a_events = (ap->a_events & ~POLLIN) | POLLIN_IGNORE_EOF;
> 
> We can't pass in flags that we don't really care about (POLLIN in
> this case) since they will cause side effects (selrecord()...).
> 
> I might actually use a new variable instead of changing `ap'.

Ok, I'll get this working on my way up to Tahoe. :)

Thanks for the advice.

-Alfred

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message