Date: Sun, 16 Nov 2003 23:51:37 -0800 From: =?UTF-8?B?IkV1Z2VuZSBNLiBLaW0g6rmA66+87ISxIg==?= <ab@astralblue.net> To: "Marc G. Fournier" <scrappy@hub.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/fs/unionfs union_vnops.c Message-ID: <3FB87E09.40904@astralblue.net> In-Reply-To: <20031114105746.M497@ganymede.hub.org> References: <200311140823.hAE8NDAb005015@repoman.freebsd.org> <20031114105746.M497@ganymede.hub.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Marc G. Fournier wrote: >Thank you, this reduces my 'list of known crash triggers' down to avoiding >the use of sockets on unionfs mounted file systems :) > > >On Fri, 14 Nov 2003, David Schultz wrote: > > >>das 2003/11/14 00:23:13 PST >> >> FreeBSD src repository >> >> Modified files: >> sys/fs/unionfs union_vnops.c >> Log: >> - A sanity check in unionfs verifies that lookups of '.' return the >> vnode of the parent. However, this check should not be performed if >> the lookup failed. This change should fix "union_lookup returning >> . not same as startdir" panics people were seeing. The bug was >> introduced by an incomplete import of a NetBSD delta in rev 1.38. >> - Move the aforementioned check out from DIAGNOSTIC. Performance >> is the least of our unionfs worries. >> - Minor reorganization. >> >> PR: 53004 >> MFC after: 1 week >> >> Revision Changes Path >> 1.103 +21 -27 src/sys/fs/unionfs/union_vnops.c >> Does this move unionfs into the `safe for general consumption' region, or is this particular problem just a tip of an iceberg? Eugene
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3FB87E09.40904>