From nobody Mon Feb 5 15:34:16 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TT9R853FTz58QNV for ; Mon, 5 Feb 2024 15:34:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TT9R80WD9z4Fpn for ; Mon, 5 Feb 2024 15:34:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20230601.gappssmtp.com header.s=20230601 header.b=mOTXVMUY; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2a00:1450:4864:20::52c) smtp.mailfrom=wlosh@bsdimp.com Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-56025fcaebaso2155461a12.0 for ; Mon, 05 Feb 2024 07:34:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1707147265; x=1707752065; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=u8bGyFtFSYuF1sVvco5YMUWJri/eWo3L1zykVsYTSiA=; b=mOTXVMUYCoqQTGM4mhImQDLYHtDGluo75+y3ip/fiuKfTb+ZRdcOKPnpFbtah0M+kQ jBOm6EMQ7LZHGgKUvawlwGkoOG+VZMqRmhRmXABqWLdRrp3G1G4Tp/D8+CFIvxjTSeNi YXeQw2QCsahzBPTKj42eDE3YirM4rf195otQpYKIER+NjGtJsycIMXoLWxFs5uKfWGZk +c82kzWkG1vD3+uoaOS5z/HTHQ4ihqJ7I1zcjcw0d7ejgo/3RVcavyZ0M2kqWI0g5vjG XYDnk6EuPANoPIAMZ86gvUVTKcUkI3jZKbFq/79dLEt5mw0o5lOg1is/mmNCD6ORg6QE jBfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707147265; x=1707752065; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u8bGyFtFSYuF1sVvco5YMUWJri/eWo3L1zykVsYTSiA=; b=RSY2jNk6hOeAGbLmXNPdRLQY3elxwVN6W/7z5kgImY+uwFE+ULi+rlzFQEG9YUQpVH LapHT+Ng9U02bcHU05UaLQSQ3M/nnoA9k3pccqp6KXBFQ/Dd+BA7hYut4SXYH/rp2DUQ Ru3M63C0MjgtBZWTZdhnIT8+ObpMBxqpY+ZNFqOmoVdsCBQLW+sPAS1FN/DnkzklVZl7 ST7D0IT49IhVa0LUTBJx3AZmv0rGpRy+y4fV5n89GlO+XKI8on2Tk3Q+eBHXhmyqAoaY /mG75lYVrRGjZQWpQGrZTZ4Ws5YTzV4SEJgQHeFmNVmNbI1NGUEu6plK7dtqk+7gbji0 lW/g== X-Gm-Message-State: AOJu0Yxo6NKRUSpqtxSj/vzqGy90Td2bW8zNfQeMjMr6nfXiLDspgmE9 CDdFkOUrt+ChVxWrp46U8LTm/XSI/zLgAOcjajhHDzQSpOSUqPLHVC4e99uLRX90rXTpwgV/lCh ub8a/2NRHe5LQ0QLYjOMpCRbQn8LePyQJZ8lkhA== X-Google-Smtp-Source: AGHT+IES0pQRSbi4TNC+2enrmeP2l5k6qtD13wlbH1rLZffLj1aRFDpKUNnui2goIilTBZ0Q8Bmkdv2t+GRBTg0HRDM= X-Received: by 2002:a05:6402:33cf:b0:55f:3cb:9c33 with SMTP id a15-20020a05640233cf00b0055f03cb9c33mr5149066edc.31.1707147265295; Mon, 05 Feb 2024 07:34:25 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org> <20240131204355.9EA2B19F@slippy.cwsent.com> In-Reply-To: From: Warner Losh Date: Mon, 5 Feb 2024 08:34:16 -0700 Message-ID: Subject: Re: git: 07c64d74917e - main - acpica: Import ACPICA 20230628 To: Cy Schubert Cc: Andriy Gapon , Jung-uk Kim , Baptiste Daroussin , src-committers , "" , "" , Dmitry Salychev Content-Type: multipart/alternative; boundary="00000000000053dd9a0610a43290" X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.992]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20230601.gappssmtp.com:s=20230601]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; R_SPF_NA(0.00)[no SPF record]; RCVD_COUNT_ONE(0.00)[1]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_TLS_LAST(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::52c:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; DKIM_TRACE(0.00)[bsdimp-com.20230601.gappssmtp.com:+] X-Rspamd-Queue-Id: 4TT9R80WD9z4Fpn --00000000000053dd9a0610a43290 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 31, 2024 at 1:59=E2=80=AFPM Warner Losh wrote: > > > On Wed, Jan 31, 2024, 1:44=E2=80=AFPM Cy Schubert > wrote: > >> In message <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org>, Andriy >> Gapon >> wri >> tes: >> > On 31/01/2024 19:40, Cy Schubert wrote: >> > > In message <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org>, >> Jung-uk Kim >> > > writ >> > > es: >> > >> On 24. 1. 31., Baptiste Daroussin wrote: >> > >>> Hello, >> > >>> >> > >>> Either this one or the previous import is breaking arm64 build >> > >>> >> > >>> --- acpi_iort.o --- >> > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:103:4: >> error: fiel >> > d >> > >>> 'data' with variable sized type 'union (unnamed union at >> > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:98:2 >> > >>> )' not at the end of a struct or class is a GNU extension >> > >>> [-Werror,-Wgnu-variable-sized-type-not-at-end] >> > >>> 103 | } data; >> > >>> | ^ >> > >> >> > >> Sorry for the breakage. I will fix it soon. >> > >> >> > >> BTW, this code was added by this: >> > >> >> > >> https://reviews.freebsd.org/D31267 >> > >> >> > >> It seems struct iort_named_component was a hack, which duplicated >> > >> ACPI_IORT_NAMED_COMPONENT but with a fixed length field >> DeviceName[32]. >> > >> Is it really necessary? >> > > >> > > Though they incorporated the WOL patch I've been using, they've brok= en >> > > poweroff. >> > >> > The poweroff issue could be because of 9cdf326b4f >> >> Thanks. I clued into that a while ago after taking a break to read the M= L. >> >> This smelled of the original WOL problem I had last year that required >> pulling the plug to allow the NIC to see the magic packet, but worse. >> Hence >> I was barking up the wrong tree. >> > > On an semi-related issue... mind if I do a proper merge commit to catch u= p > and not leave hidden landmines for the future? > OK. I'll do a proper merge commit. We've accumulated a few dozen conflicts I'll have to sort out (though I think they are all in files we don't user or have deleted). Warner > Warner > >> >> -- >> Cheers, >> Cy Schubert >> FreeBSD UNIX: Web: https://FreeBSD.org >> NTP: Web: https://nwtime.org >> >> e^(i*pi)+1=3D0 >> >> >> --00000000000053dd9a0610a43290 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Jan 31, 2024 at 1:59=E2=80=AF= PM Warner Losh <imp@bsdimp.com>= wrote:


On Wed, Jan 31, 2024, 1:44=E2=80=AFPM Cy Schubert <Cy.Schubert@cschube= rt.com> wrote:
In message <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org>, = Andriy Gapon
wri
tes:
> On 31/01/2024 19:40, Cy Schubert wrote:
> > In message <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org&g= t;, Jung-uk Kim
> > writ
> > es:
> >> On 24. 1. 31., Baptiste Daroussin wrote:
> >>> Hello,
> >>>
> >>> Either this one or the previous import is breaking arm64 = build
> >>>
> >>> --- acpi_iort.o ---
> >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:10= 3:4: error: fiel
> d
> >>> 'data' with variable sized type 'union (unnam= ed union at
> >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:98= :2
> >>> )' not at the end of a struct or class is a GNU exten= sion
> >>> [-Werror,-Wgnu-variable-sized-type-not-at-end]
> >>>=C2=A0 =C2=A0 =C2=A0103 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0} data;
> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0^
> >>
> >> Sorry for the breakage.=C2=A0 I will fix it soon.
> >>
> >> BTW, this code was added by this:
> >>
> >> https://reviews.freebsd.org/D31267 > >>
> >> It seems struct iort_named_component was a hack, which duplic= ated
> >> ACPI_IORT_NAMED_COMPONENT but with a fixed length field Devic= eName[32].
> >> Is it really necessary?
> >
> > Though they incorporated the WOL patch I've been using, they&= #39;ve broken
> > poweroff.
>
> The poweroff issue could be because of 9cdf326b4f

Thanks. I clued into that a while ago after taking a break to read the ML.<= br>
This smelled of the original WOL problem I had last year that required
pulling the plug to allow the NIC to see the magic packet, but worse. Hence=
I was barking up the wrong tree.

On an semi-related issue... mind if I do a = proper merge commit to catch up and not leave hidden landmines for the futu= re?

OK. I'll do a proper me= rge commit. We've accumulated a few dozen conflicts I'll have to so= rt out (though I think they
are all in files we don't user or= have deleted).

Warner
=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
Warner

--
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:=C2=A0 <cy@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 ht= tps://FreeBSD.org
NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<cy@nwtime.org>=C2=A0 =C2= =A0 Web:=C2=A0 https://nwtime.org

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 e^(i*pi)+1=3D0


--00000000000053dd9a0610a43290--