From owner-freebsd-bugs@FreeBSD.ORG Fri Oct 4 16:20:02 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 27FFDDD1 for ; Fri, 4 Oct 2013 16:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 123332708 for ; Fri, 4 Oct 2013 16:20:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r94GK1R8007032 for ; Fri, 4 Oct 2013 16:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r94GK0mZ007025; Fri, 4 Oct 2013 16:20:00 GMT (envelope-from gnats) Date: Fri, 4 Oct 2013 16:20:00 GMT Message-Id: <201310041620.r94GK0mZ007025@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Jilles Tjoelker Subject: Re: bin/182098: [patch] Change kldxref fts_open ordering so it produces a consistent linker.hints between machines of the same architecture. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Jilles Tjoelker List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 16:20:02 -0000 The following reply was made to PR bin/182098; it has been noted by GNATS. From: Jilles Tjoelker To: Derek Schrock Cc: bug-followup@FreeBSD.org Subject: Re: bin/182098: [patch] Change kldxref fts_open ordering so it produces a consistent linker.hints between machines of the same architecture. Date: Fri, 4 Oct 2013 18:19:21 +0200 On Sat, Sep 28, 2013 at 05:06:00PM -0400, Derek Schrock wrote: > Looks like I wanted to postpone the last message instead of sending it: > Ok I see what you mean by using FTS_D. Everything looks good to me, I > compared the linker.hints generated by the two system from the initial > description. They're the same. > However, I slightly modified the testing script from your last comment > and found three .ko files that don't seem to generate an entry in the > linker.hints files: > Patched kldxref: > $ /usr/src/usr.sbin/kldxref/kldxref -R /boot/ > $ dir="kernel"; strings="$(strings /boot/$dir/linker.hints)"; for f in /boot/"$dir"/*.ko ; do f="${f##*/}"; case "$strings" in *"$f"*) ;; *) echo "what? $f" ;; esac; done > what? musb.ko > what? scc.ko > what? uss820dci.ko > System kldxref: > $ kldxref -R /boot/ > $ dir="kernel"; strings="$(strings /boot/$dir/linker.hints)"; for f in /boot/"$dir"/*.ko ; do f="${f##*/}"; case "$strings" in *"$f"*) ;; *) echo "what? $f" ;; esac; done > what? musb.ko > what? scc.ko > what? uss820dci.ko > Can we assume this isn't a problem with patch since the system kldxref > doesn't generate a linker.hints with strings that reference those ko > files? Yes, this seems not the fault of the patch. It is possible that these three modules do not actually work. -- Jilles Tjoelker