Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Feb 2023 22:27:31 +0000
From:      Jessica Clarke <jrtc27@freebsd.org>
To:        =?utf-8?Q?Jean-S=C3=A9bastien_P=C3=A9dron?= <dumbbell@FreeBSD.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Subject:   Re: git: b1a9e570fe2d - main - linuxkpi: Add `strscpy_pad()` to <linux/string.h>
Message-ID:  <BC964557-C184-435B-ABE5-C26AED29EED0@freebsd.org>
In-Reply-To: <202302152226.31FMQQV8093715@gitrepo.freebsd.org>
References:  <202302152226.31FMQQV8093715@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 15 Feb 2023, at 22:26, Jean-S=C3=A9bastien P=C3=A9dron =
<dumbbell@FreeBSD.org> wrote:
>=20
> The branch main has been updated by dumbbell (ports committer):
>=20
> URL: =
https://cgit.FreeBSD.org/src/commit/?id=3Db1a9e570fe2da0a43c41327d7ce21b27=
bf8257b8
>=20
> commit b1a9e570fe2da0a43c41327d7ce21b27bf8257b8
> Author:     Jean-S=C3=A9bastien P=C3=A9dron <dumbbell@FreeBSD.org>
> AuthorDate: 2023-02-14 23:46:13 +0000
> Commit:     Jean-S=C3=A9bastien P=C3=A9dron <dumbbell@FreeBSD.org>
> CommitDate: 2023-02-15 22:19:41 +0000
>=20
>    linuxkpi: Add `strscpy_pad()` to <linux/string.h>
>=20
>    It's the same as `strscpy()` except that it fills the rest of the
>    destination buffer with zeroes if the source buffer is shorter.
>=20
>    Reviewed by:    manu
>    Approved by:    manu
> ---
> sys/compat/linuxkpi/common/include/linux/string.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>=20
> diff --git a/sys/compat/linuxkpi/common/include/linux/string.h =
b/sys/compat/linuxkpi/common/include/linux/string.h
> index 65422cac629c..20c3729aaf12 100644
> --- a/sys/compat/linuxkpi/common/include/linux/string.h
> +++ b/sys/compat/linuxkpi/common/include/linux/string.h
> @@ -207,6 +207,15 @@ strscpy(char* dst, const char* src, size_t len)
> 	return (-E2BIG);
> }
>=20
> +static inline ssize_t
> +strscpy_pad(char* dst, const char* src, size_t len)
> +{
> +

style(9) doesn=E2=80=99t need this blank line any more, please stop =
including
them in your commits.

Jess

> +	bzero(dst, len);
> +
> +	return (strscpy(dst, src, len));
> +}
> +
> static inline void *
> memset32(uint32_t *b, uint32_t c, size_t len)
> {




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BC964557-C184-435B-ABE5-C26AED29EED0>