From owner-p4-projects@FreeBSD.ORG Sat May 30 12:24:50 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 9A7921065677; Sat, 30 May 2009 12:24:50 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 512801065672 for ; Sat, 30 May 2009 12:24:49 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe09.tele2.se [212.247.155.1]) by mx1.freebsd.org (Postfix) with ESMTP id EF60D8FC16 for ; Sat, 30 May 2009 12:24:48 +0000 (UTC) (envelope-from hselasky@c2i.net) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.0 c=1 a=t0nNz8v6BrwA:10 a=3W0jh48ptVil740CxZAA:9 a=9yvYqD2Nb6ukYw2vl8HBYEl5UN4A:4 Received: from [62.113.132.61] (account mc467741@c2i.net HELO [10.37.1.92]) by mailfe09.swip.net (CommuniGate Pro SMTP 5.2.13) with ESMTPA id 907571389; Sat, 30 May 2009 14:24:47 +0200 From: Hans Petter Selasky To: Sylvestre Gallon Date: Sat, 30 May 2009 14:28:53 +0200 User-Agent: KMail/1.9.7 References: <200905301128.n4UBSGad022347@repoman.freebsd.org> In-Reply-To: <200905301128.n4UBSGad022347@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200905301428.54367.hselasky@c2i.net> Cc: Perforce Change Reviews Subject: Re: PERFORCE change 163077 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2009 12:24:51 -0000 On Saturday 30 May 2009, Sylvestre Gallon wrote: > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0ret =3D libusb20_dev_proces= s(devh->os_priv); > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (ret =3D=3D 0 || LIBUSB2= 0_ERROR_NO_DEVICE) ret =3D=3D LIBUSB20_ERROR_NO_DEVICE One note: libusb20 is not thread safe. So you might need an additional lock for that,= =20 I.E. when you call libusb20_dev_process() and libusb20_tr_submit()++ must b= e=20 atomic. If this cannot be solved in libusb10, I will do something. =2D-HPS