Date: Wed, 08 Apr 2015 20:23:26 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r383191 - head/Mk Message-ID: <5525D48E.5090305@FreeBSD.org> In-Reply-To: <20150408232144.GX21982@hades.panopticon> References: <201504040535.t345ZJ9M028396@svn.freebsd.org> <20150408194202.GA45809@hades.panopticon> <5525A9C1.5010003@FreeBSD.org> <20150408232144.GX21982@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Cgv6b6OHmFiKEvdRrUKFJFpIhGOg8tU24 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/8/2015 6:21 PM, Dmitry Marakasov wrote: > * Bryan Drewery (bdrewery@FreeBSD.org) wrote: >=20 >>>> Re-enable and rework check added in r370464 to validate the first = CATEGORY >>>> is set properly. The problem causing the revert in r370475 was fi= xed in >>>> r383190. >>>> =20 >>>> With hat: portmgr >>> >>> This breaks countless usecases when port is build which does not belo= ng >>> to the ports tree. >> >> Please name even 1 case. >=20 > I have a lot of WIP ports in flat directory. Tons of custom port > repositories on github with flat structure. Short of more details, that does not sound like a supported setup. I can't read your mind. Please give me a specific case or I can't help. >=20 >> Building a port with the wrong first CATEGORY results in a broken >> package as the origin is wrong. >=20 > I'm not talking about wrong categories, I'm talking about ports outside= > of the ports tree. These should build perfectly fine. >=20 >>> Afaik, we have that information in ports - based on >>> that PORTSDIR is chosen. The same mechanism should be used here to >>> conditionally enable the check. >> >> That made no sense. >=20 > Explain. >=20 I do not understand what you are trying to say. It makes no sense. --=20 Regards, Bryan Drewery --Cgv6b6OHmFiKEvdRrUKFJFpIhGOg8tU24 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVJdSOAAoJEDXXcbtuRpfPIPMIAIf1u3nzbstzk1ss2GYGRfOJ 8/sx0P17FX/Rx8eqlp6/KfTWQlkAAGlzh9i8aJMn/yFRJLmP0cTZ+Iaxk8tB9mpc 49aOtLJu80JdBmrhNfoS+2euo5JmjuCEndbdLGZFbfu2GJkBqRA1BGe++Ydf5b5y tZOpjcKk+UxU8A4ZUTVBB2dIieTARZkyFDF9aMP7QocytdBYt8mhrI+Bhb/zZn10 qhjztH2gB9aAhgnFVMBPa+gerWHLPfO3Q5siQSClXXeqMHb6fJEu2T50Pa0e/vSM mvmDIzzXS2KbRCIoXdAKsGwlrx0IXB03yp7JUhKhcAl0p5ItmK2kZqfHHrsMYdw= =16db -----END PGP SIGNATURE----- --Cgv6b6OHmFiKEvdRrUKFJFpIhGOg8tU24--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5525D48E.5090305>