From owner-cvs-all@FreeBSD.ORG  Thu Nov 10 14:21:57 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4516816A41F;
	Thu, 10 Nov 2005 14:21:57 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DA73843D45;
	Thu, 10 Nov 2005 14:21:56 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.48.2])
	by phk.freebsd.dk (Postfix) with ESMTP id D257FBC66;
	Thu, 10 Nov 2005 14:21:54 +0000 (UTC)
To: Scott Long <scottl@samsco.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Thu, 10 Nov 2005 06:57:15 MST."
	<437351BB.6000103@samsco.org> 
Date: Thu, 10 Nov 2005 15:21:54 +0100
Message-ID: <5761.1131632514@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: Doug White <dwhite@FreeBSD.org>, cvs-src@FreeBSD.org,
	src-committers@FreeBSD.org, Doug White <dwhite@gumbysoft.com>,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs
	devfs_vnops.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Nov 2005 14:21:57 -0000

In message <437351BB.6000103@samsco.org>, Scott Long writes:

>Putting the cookie into the dirent means either changing the size of the
>dirent struct and breaking the userland ABI (almost as bad as changing
>the size of stat, but not quite), or making a 'kdirent' struct and then
>manually shifting and copying it to a dirent struct.

Not really that bad.

My idea was to make a 
	struct kdirent {
		struct dirent	foo;
		cookie stuff	bar;
	}

Filesystems would call vfs_read_dirent() with a struct kdirent and
depending on the userland/kernel flag in the uio vfs_read_dirent()
would copy either the entire kdirent or only the userspace dirent.


>What I really think this is is a ploy by PHK to get someone motivated to
>fix it for him ;-)

I'm generally in favour of people doing work so I don't have to but
in this particular case that was not the motivation :-)

(At least you can't prove anything!)

Poul-Henning

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.