From nobody Fri Feb 7 18:53:04 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YqNQX0F97z5mfrC; Fri, 07 Feb 2025 18:53:08 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta004.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YqNQW5JGSz3K0Y; Fri, 07 Feb 2025 18:53:07 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4003a.ext.cloudfilter.net ([10.228.9.183]) by cmsmtp with ESMTPS id gQTYtuEwFyLQGgTTOtZK3Y; Fri, 07 Feb 2025 18:53:06 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id gTTNteRbSWbOagTTOtoAIa; Fri, 07 Feb 2025 18:53:06 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=Q5lx4J2a c=1 sm=1 tr=0 ts=67a65692 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=T2h4t0Lz3GQA:10 a=6I5d2MoRAAAA:8 a=NEAV23lmAAAA:8 a=EkcXrb_YAAAA:8 a=pGLkceISAAAA:8 a=YxBL1-UpAAAA:8 a=jaCygfFNoWxb7CcOSigA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 3848A692; Fri, 07 Feb 2025 10:53:04 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 260B5225; Fri, 07 Feb 2025 10:53:04 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Mark Johnston cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: d3b1dcb408e2 - main - acpi_iicbus: install the address space handler by default In-reply-to: <202502071842.517IgxJE051814@gitrepo.freebsd.org> References: <202502071842.517IgxJE051814@gitrepo.freebsd.org> Comments: In-reply-to Mark Johnston message dated "Fri, 07 Feb 2025 18:42:59 +0000." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 07 Feb 2025 10:53:04 -0800 Message-Id: <20250207185304.260B5225@slippy.cwsent.com> X-CMAE-Envelope: MS4xfKy3qw/c6YxB6thqb19B0pkjSGUtZBFDkUrCHc+1BbtJAD4k/37KT5rA09kXDnohkYUpPGegba8l5YPeToOUvpBsGCEyLOtEb1pqNM8VJRQP2f3lQDPv HJwRskF/S5PI8jNZ3YBKZ+E+7pVixqrTCE9nJUhUmtio5Z8I+bVfyYBX4fDTuMrUzSnX0e9Dviv4Vz6mo5SSfuNs/2qDeUwiuCYbhO5N97I1SW5EX4wRzDNX V8nVTm2A7DUBxjD5wwNZnwi9riK2EuE8jGnqdx+EMPZFO9CygsKdDt+7A448S0Y5a2CpIAsL981qK0aP0Kuv+BI7bHweoV27oglQ4r4Gf9s= X-Rspamd-Queue-Id: 4YqNQW5JGSz3K0Y X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] In message <202502071842.517IgxJE051814@gitrepo.freebsd.org>, Mark Johnston wri tes: > The branch main has been updated by markj: > > URL: https://cgit.FreeBSD.org/src/commit/?id=d3b1dcb408e2f63845aee5508fe4c73d > b1f94b58 > > commit d3b1dcb408e2f63845aee5508fe4c73db1f94b58 > Author: Ahmad Khalifa > AuthorDate: 2025-01-26 18:48:17 +0000 > Commit: Mark Johnston > CommitDate: 2025-02-07 18:20:00 +0000 > > acpi_iicbus: install the address space handler by default > > Signed-off-by: Ahmad Khalifa > > Reviewed by: wulf > Pull Request: https://github.com/freebsd/freebsd-src/pull/1583 The question why remains to be answered. We should try to teach contributors to answer the question why in their commit log messages. I think most committers do a pretty good job of that. We should expect contributors, who may potentially become committers, to answer this question too in their commits. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0