From nobody Wed May 27 21:42:10 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gQjkp5wyXz6fkQl for ; Wed, 27 May 2026 21:42:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gQjkp3K9tz3X4k for ; Wed, 27 May 2026 21:42:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779918130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Qt7a4zGEUYD1Jtb9f4W/NzSc9T961xAIL2N4HUa+zYY=; b=uoGmUYLS8qYztNL3BNY7Vl1251JvVFhPG6EQKqj+vlhf6ZodU5giuIBnRqjyH2v4HLfWQe GdujoGGRcvm9K0ywmlQ9qzbmkM8ojz8LT7JwJKi4RyB3xo/OQMdqyPi0lEyFJqp3FOC5Ku yKE3AuR++kG0DanRcNrpr85R1eHrQhRW8S7BFrOCTuK+Uvyb7mZwyKCZO3WG9PfbptOqSE RRbRIRezdDp4nfBcvOJIgeAVe7kPjG8BejKqfLvB27km+OiWdmlf2OOOebAolBDqSecRLk Dlq6veryS3CnB7oiejg0DmHXs4v00dqu+K8yvbNWFkYH70MhrpfVmEMdcRaMSw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779918130; a=rsa-sha256; cv=none; b=Mbta7q1oHybVZWjGygH/3dMTbAN3nptTH7p/4SprXqCVei/xMBTdww3xA0RNYFRFqgrZBo RGKMYIYj6Y79WwIjAQOfNh76V3pkwr3yhrbHTsDuvvogYaLPyVJd1kW24VZPFP4nZlL9lg drGMmr8k9177GvF5crol3OSlt0DN3T+FM6XApq9Xy1lOUqIrhaDSPFJP/OeEhIeBtmqNe6 gR6TvIGTeOP5VaaV8DG/4TcJZkocYSNBezPvkTifHPxe+NwNVZhqS9y+kzu9ZLWNSHKSPn ocsKkBSTt8o/9I3G64s1yviLpbO62vO9nHI8YsuqDSX2w3xR6uYsIquYhmO3xw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779918130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Qt7a4zGEUYD1Jtb9f4W/NzSc9T961xAIL2N4HUa+zYY=; b=w+n2DgnTC37ZWCY8emi51wCc/4Q7+SG9zkPHG9YW9WBtFd0Jbp/8ITXLvT3ehP0cIJ3LfI Dbbhmun9mLg8/CpFthlht/kGIh+qUHHjmK+FGBOWVNZX9jQwqiYdlXv8y27me4NmrNxgT+ BxcP/2Og24s47Z9AhpiihnuQZ9idSf+NPaa6AO7J/Ezo/CVGNEQ07Z1vfpAC0ht2nUxuUA FyJ0O4OVYylwEtno4Vj3ofHYWZfyckzKaLLkIa4wszLpbdbFFW5BXrCUiWZCOe7tQi7EhH 8zRno+6kh2REWTC7VA6KA6Nn7dWTT5QlgTWWUHyrxKBCHfL6PwjICWRGgwfCaA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gQjkp2g1sz2Ys for ; Wed, 27 May 2026 21:42:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26c3f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 27 May 2026 21:42:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Alex Richardson From: Dimitry Andric Subject: git: 3c3a20199ac9 - stable/15 - netmap: silence -Wdefault-const-init-field-unsafe warning List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 3c3a20199ac9ef10f2bd90c0bd6e1c862578ab0d Auto-Submitted: auto-generated Date: Wed, 27 May 2026 21:42:10 +0000 Message-Id: <6a176532.26c3f.16053612@gitrepo.freebsd.org> The branch stable/15 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=3c3a20199ac9ef10f2bd90c0bd6e1c862578ab0d commit 3c3a20199ac9ef10f2bd90c0bd6e1c862578ab0d Author: Alex Richardson AuthorDate: 2025-12-16 18:09:57 +0000 Commit: Dimitry Andric CommitDate: 2026-05-27 21:41:03 +0000 netmap: silence -Wdefault-const-init-field-unsafe warning The netmap_ring struct starts with various const members and rencent clang warns about leaving them uninitialized. Having them const in the first place is highly suspicious since they are updated with various macros but using hand-coded __DECONST(). But fixing that is a more invasive change that I am unable to test. ``` .../freebsd/sys/dev/netmap/netmap_kloop.c:320:21: error: default initialization of an object of type 'struct netmap_ring' with const member leaves the object uninitialized [-Werror,-Wdefault-const-init-field-unsafe] 320 | struct netmap_ring shadow_ring; /* shadow copy of the netmap_ring */ | ^ .../freebsd/sys/net/netmap.h:290:16: note: member 'buf_ofs' declared 'const' here 290 | const int64_t buf_ofs; | ^ ``` Test Plan: Compiles Reviewed by: vmaffione, jhb MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D52568 (cherry picked from commit 2ed21f90906b230476d3f12ff9dce0e2c4642af2) --- sys/dev/netmap/netmap_kloop.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/dev/netmap/netmap_kloop.c b/sys/dev/netmap/netmap_kloop.c index ba9e67076e72..ac3ca2d8d21f 100644 --- a/sys/dev/netmap/netmap_kloop.c +++ b/sys/dev/netmap/netmap_kloop.c @@ -161,7 +161,8 @@ netmap_sync_kloop_tx_ring(const struct sync_kloop_ring_args *a) struct netmap_kring *kring = a->kring; struct nm_csb_atok *csb_atok = a->csb_atok; struct nm_csb_ktoa *csb_ktoa = a->csb_ktoa; - struct netmap_ring shadow_ring; /* shadow copy of the netmap_ring */ + /* shadow copy of the netmap_ring */ + struct netmap_ring shadow_ring = {0}; #ifdef SYNC_KLOOP_POLL bool more_txspace = false; #endif /* SYNC_KLOOP_POLL */ @@ -317,7 +318,8 @@ netmap_sync_kloop_rx_ring(const struct sync_kloop_ring_args *a) struct netmap_kring *kring = a->kring; struct nm_csb_atok *csb_atok = a->csb_atok; struct nm_csb_ktoa *csb_ktoa = a->csb_ktoa; - struct netmap_ring shadow_ring; /* shadow copy of the netmap_ring */ + /* shadow copy of the netmap_ring */ + struct netmap_ring shadow_ring = {0}; int dry_cycles = 0; #ifdef SYNC_KLOOP_POLL bool some_recvd = false;