Date: Wed, 09 Sep 2015 21:37:28 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r396521 - in head/lang/mosh: . files Message-ID: <1te7-bczr-wny@FreeBSD.org> In-Reply-To: <201509091726.t89HQETZ003966@repo.freebsd.org> (Alexey Dokuchaev's message of "Wed, 9 Sep 2015 17:26:14 %2B0000 (UTC)") References: <201509091726.t89HQETZ003966@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Alexey Dokuchaev <danfe@FreeBSD.org> writes:
> - Propagate available SIMD support down to the compiler (x86 only)
[...]
> +.if ${MACHINE_CPU:Msse3}
> +CONFIGURE_ENV+= MOSH_OPTS="-msse3 -mfpmath=sse"
> +.elif ${MACHINE_CPU:Msse2}
> +CONFIGURE_ENV+= MOSH_OPTS="-msse2 -mfpmath=sse"
> +.elif ${MACHINE_CPU:Msse}
> +CONFIGURE_ENV+= MOSH_OPTS="-msse -mfpmath=sse"
> +.elif ${MACHINE_CPU:Mmmx}
> +CONFIGURE_ENV+= MOSH_OPTS="-mmmx"
> .endif
Why add cargo cult optimization? Nothing in i?86 code seems to rely on
__SSE* defines or *intrin.h. Besides, -mfpmath=sse, -msse2 and -msse are
default on amd64 which means the following chunk is always enabled:
// extlibs/gc-cvs/libatomic_ops/src/atomic_ops/sysdeps/standard_ao_double_t.h
#if (defined(__x86_64__) && defined(__GNUC__)) || defined(_WIN64)
# include <xmmintrin.h>
typedef __m128 double_ptr_storage;
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQF8BAEBCgBmBQJV8Ip4XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3b7Z8IAIKvnrxWiU9X8vACBAJJd3gs
Wg6Uf7zNbOFjOEsIndKlhsWq7RZymFXfYvAQoWUWraWMoQCrU2l+jsm3rm3bDAPJ
rgnA/ot0XNrmhbTV9OOAXoaSWFDc+wX3KRksrjUZBlNjCtj81BfQorLgIz66ITfX
h06AIegs0jHto8KjItLu7IYFL4UYWTj1TH85dfsRPB5x6CnANYsrWmjG50qsD4QH
9n8TQPZ7JM10awVRwJbLarDpTfjtkJfanPG1aTB/chaJyhqcrGECU/+aji7SFvV5
GFWmB2l1v/S8Pu1dAnYfVCMAgCU8xzj880vbDNh0/4oiYNMfj7g90X86sUF3/uc=
=1SiM
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1te7-bczr-wny>