From owner-cvs-all Thu Feb 27 13:12:19 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BADC37B401; Thu, 27 Feb 2003 13:12:18 -0800 (PST) Received: from baraca.united.net.ua (vlan1.baraca.united.net.ua [195.234.212.67]) by mx1.FreeBSD.org (Postfix) with ESMTP id 469FB43F85; Thu, 27 Feb 2003 13:12:16 -0800 (PST) (envelope-from max@vega.com) Received: from vega.vega.com (root@xDSL-2-2.united.net.ua [193.111.9.226]) by baraca.united.net.ua (8.12.6/8.12.6) with ESMTP id h1RLC4do015729; Thu, 27 Feb 2003 23:12:05 +0200 (EET) (envelope-from max@vega.com) Received: from vega.vega.com (max@localhost.vega.com [127.0.0.1]) by vega.vega.com (8.12.6/8.12.5) with ESMTP id h1RLC5Uk025709; Thu, 27 Feb 2003 23:12:05 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Received: (from max@localhost) by vega.vega.com (8.12.6/8.12.5/Submit) id h1RLC5Ut025708; Thu, 27 Feb 2003 23:12:05 +0200 (EET) Date: Thu, 27 Feb 2003 23:12:05 +0200 From: Maxim Sobolev To: Will Andrews Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall index.c Message-ID: <20030227211205.GF17255@vega.vega.com> References: <200302272043.h1RKhq9f048530@repoman.freebsd.org> <20030227205742.GT37397@procyon.firepipe.net> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20030227205742.GT37397@procyon.firepipe.net> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Feb 27, 2003 at 12:57:42PM -0800, Will Andrews wrote: > On Thu, Feb 27, 2003 at 12:43:52PM -0800, Maxim Sobolev wrote: > > Log: > > Increase size of the static buffer used to hold runtime dependency list > > read from CD from 2k to 16k, because in the modern world of meta-packages > > (Gnome et al) the length of this list could easily owerflow limit causing > > strange things to happen, ranging from installation failure due to list > > truncation to complete stack trashing (there is very vague bounds checking). > > For example, x11/gnome2-fifth-toe runtime dependencies list is 2,418 bytes > > long. > > Why not do it right the first time? Make it a dynamic buffer > instead of a static one. Because this would mean major rewrite of the code involved - there are static buffers all over the place. Personally, I don't have a time to do, and what is even more important to test, it right now. Feel free, however to pick it up where I left. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message