From owner-cvs-all Fri Jul 12 2:52:11 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C32A537B400; Fri, 12 Jul 2002 02:52:08 -0700 (PDT) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D7B043E31; Fri, 12 Jul 2002 02:52:08 -0700 (PDT) (envelope-from dl-freebsd@catspoiler.org) Received: from mousie.catspoiler.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.12.5/8.12.5) with ESMTP id g6C9pxwr013357; Fri, 12 Jul 2002 02:52:03 -0700 (PDT) (envelope-from dl-freebsd@catspoiler.org) Message-Id: <200207120952.g6C9pxwr013357@gw.catspoiler.org> Date: Fri, 12 Jul 2002 02:51:59 -0700 (PDT) From: Don Lewis Subject: Re: cvs commit: src/sys/netinet udp_usrreq.c To: hsu@FreeBSD.org Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <0GZ400HU8PNLLG@mta7.pltn13.pbi.net> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 12 Jul, Jeffrey Hsu wrote: > > Comparing udp_getcred() with tcp_getcred(), the missing lock looked like > > an oversight. > > Okay, I see the confusion. I had the same question when I reviewed Jennifer's > patch, but decided to err on the side of conservatism and allow it. I actually > believe that lock is unnecessary in tcp_getcred(). Now that I look at it, I think TCP has the opposite problem. I don't see either inp or tcbinfo being locked in tcp_close() before it calls in_pcbdetach(). To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message