From owner-svn-src-stable@freebsd.org  Fri Mar 30 02:20:24 2018
Return-Path: <owner-svn-src-stable@freebsd.org>
Delivered-To: svn-src-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2128F66DF8;
 Fri, 30 Mar 2018 02:20:24 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 53BB070CA8;
 Fri, 30 Mar 2018 02:20:24 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 4BCD516296; Fri, 30 Mar 2018 02:20:24 +0000 (UTC)
Date: Fri, 30 Mar 2018 02:20:24 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: rgrimes@freebsd.org
Cc: Ian Lepore <ian@freebsd.org>, src-committers@freebsd.org,
 svn-src-stable@freebsd.org, svn-src-all@freebsd.org,
 svn-src-stable-11@freebsd.org, Marcelo Araujo <araujo@freebsd.org>
Subject: Re: svn commit: r331728 - in stable/11/etc: . rc.d
Message-ID: <20180330022024.GA60787@FreeBSD.org>
References: <1522340373.49673.112.camel@freebsd.org>
 <201803291633.w2TGXinX064128@pdx.rh.CN85.dnsmgr.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201803291633.w2TGXinX064128@pdx.rh.CN85.dnsmgr.net>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
 <svn-src-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable>, 
 <mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable/>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
 <mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Mar 2018 02:20:24 -0000

On Thu, Mar 29, 2018 at 09:33:44AM -0700, Rodney W. Grimes wrote:
> ...
> It seems that the Phabricator review system is somewhat disfunctional
> in that actual review is only happening in some cases.  Some people
> have even stated they flat out hate it.  Others say that it is the
> way to go.

As imp@ and ian@ had said it does not look too bad in src land, where
people use it more or less correctly (putting up disputable changes,
seeking review from people with better expertise or domain knowledge,
etc.).  It's far worse in ports when people often abuse it for trivial
changes that should just be committed (and usually they are, without
any activity in the Phab expect opening a DR and then closing it).

./danfe