From owner-svn-src-all@freebsd.org Wed Aug 15 07:36:38 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 26AF81078C50; Wed, 15 Aug 2018 07:36:38 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C4C417E923; Wed, 15 Aug 2018 07:36:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (unknown [51.52.172.98]) by mail.baldwin.cx (Postfix) with ESMTPSA id CADA210AFCD; Wed, 15 Aug 2018 03:36:06 -0400 (EDT) Subject: Re: svn commit: r337674 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys To: Matt Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201808120209.w7C297Ub018593@repo.freebsd.org> From: John Baldwin Message-ID: Date: Wed, 15 Aug 2018 07:45:02 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <201808120209.w7C297Ub018593@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Wed, 15 Aug 2018 03:36:36 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 07:36:38 -0000 On 8/12/18 3:09 AM, Matt Macy wrote: > Author: mmacy > Date: Sun Aug 12 02:09:06 2018 > New Revision: 337674 > URL: https://svnweb.freebsd.org/changeset/base/337674 > > Log: > Restore legacy dnode_phys layout on tier 2 arches > > Evidently gcc4 doesn't support anonymous union members It does. We use it in 'struct mbuf'. It does require -fms-extensions which we enable for kernel builds. Perhaps ZFS is missing this flag due to using custom build flags and/or rules? -- John Baldwin