Date: Mon, 2 Feb 2004 01:12:31 +0100 (CET) From: Pav Lucistnik <pav@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/62238: enable USE_SIZE by default Message-ID: <200402020012.i120CVJ0056078@hood.oook.cz> Resent-Message-ID: <200402020020.i120KHBL002923@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 62238
>Category: ports
>Synopsis: enable USE_SIZE by default
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Feb 01 16:20:17 PST 2004
>Closed-Date:
>Last-Modified:
>Originator: Pav Lucistnik
>Release: FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD hood.oook.cz 5.2-CURRENT FreeBSD 5.2-CURRENT #0: Fri Jan 30 00:23:59 CET 2004 root@hood.oook.cz:/usr/obj/usr/src/sys/PAV i386
>Description:
I propose enabling USE_SIZE functionality in bsd.port.mk by default,
and dropping USE_SIZE variable altogether (ie remove it from all
ports Makefile it already got in).
Having SIZE in distinfo proved to be very popular feature among
committers lately and once all ports have SIZE recorded, we can
start doing fancy stuff like calculating total download size
for a port and it's dependencies, etc...
>How-To-Repeat:
>Fix:
Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.483
diff -a -u -r1.483 bsd.port.mk
--- bsd.port.mk 24 Jan 2004 01:26:30 -0000 1.483
+++ bsd.port.mk 2 Feb 2004 00:09:55 -0000
@@ -4091,9 +4091,7 @@
@(cd ${DISTDIR}; \
for file in ${_CKSUMFILES}; do \
${MD5} $$file >> ${MD5_FILE}; \
- if [ -n "${USE_SIZE}" ]; then \
- ${ECHO_CMD} "SIZE ($$file) = "`${LS} -ALln $$file | ${AWK} '{print $$5}'` >> ${MD5_FILE}; \
- fi; \
+ ${ECHO_CMD} "SIZE ($$file) = "`${LS} -ALln $$file | ${AWK} '{print $$5}'` >> ${MD5_FILE}; \
done)
@for file in ${_IGNOREFILES}; do \
${ECHO_CMD} "MD5 ($$file) = IGNORE" >> ${MD5_FILE}; \
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200402020012.i120CVJ0056078>