From owner-svn-src-all@freebsd.org Fri Sep 30 17:35:42 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 216B5C03036; Fri, 30 Sep 2016 17:35:42 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 002641533; Fri, 30 Sep 2016 17:35:41 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id B742910AF74; Fri, 30 Sep 2016 13:35:40 -0400 (EDT) From: John Baldwin To: Justin Hibbits Cc: Nathan Whitehorn , src-committers , svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r306473 - head/sys/dev/fdt Date: Fri, 30 Sep 2016 10:16:15 -0700 Message-ID: <1997344.mDN9V1EHvR@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-PRERELEASE; KDE/4.14.10; amd64; ; ) In-Reply-To: References: <201609300248.u8U2meEe014568@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Fri, 30 Sep 2016 13:35:40 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 17:35:42 -0000 On Thursday, September 29, 2016 11:38:13 PM Justin Hibbits wrote: > If I remember correctly, newbus will throw an error if you try to create > two devices with the same number. Applying the logic of using the > cell-index property for all device nodes, if two sub buses from simplebus > have the same set of child nodes, with the same cell-index property values, > one set of children would error and not attach. Of course this change is > only for simplebus, so shouldn't have too big an impact. Yes, new-bus doesn't let you add devices with the same unit. We used to force the unit of PCI bridges/buses but removed all that to better cope with multi-domain systems. I think in general it's best to use wildcard units outside of something like hints. -- John Baldwin