From owner-cvs-all@FreeBSD.ORG  Sat Oct 30 15:42:06 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 10AC916A4CE; Sat, 30 Oct 2004 15:42:06 +0000 (GMT)
Received: from sakura.ninth-nine.com (sakura.ninth-nine.com [219.127.74.120])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8439B43D31; Sat, 30 Oct 2004 15:42:05 +0000 (GMT)
	(envelope-from nork@FreeBSD.org)
Received: from nadesico.ninth-nine.com (nadesico.ninth-nine.com
	[219.127.74.122]) by sakura.ninth-nine.com (8.13.1/8.13.1/NinthNine) with SMTP
	id i9UFg4pH019425; Sun, 31 Oct 2004 00:42:04 +0900 (JST) (envelope-from
	nork@FreeBSD.org)
Date: Sun, 31 Oct 2004 00:42:04 +0900 (JST)
Message-Id: <200410301542.i9UFg4pH019425@sakura.ninth-nine.com>
From: Norikatsu Shigemura <nork@FreeBSD.org>
To: Adam Weinberger <adamw@FreeBSD.org>
In-Reply-To: <20041030140559.GB83224@toxic.magnesium.net>
References: <200410300322.i9U3MNsA017587@repoman.freebsd.org>
	<20041030211415.3330b88b.nork@FreeBSD.org>
	<20041030140559.GB83224@toxic.magnesium.net>
X-Mailer: Sylpheed version 0.9.12-gtk2-20040918 (GTK+ 2.4.9;
	i386-portbld-freebsd6.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.5.10
	(sakura.ninth-nine.com [219.127.74.121]); Sun, 31 Oct 2004 00:42:04 +0900
	(JST)
cc: cvs-ports@FreeBSD.org
cc: ports-committers@FreeBSD.org
cc: nork@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ahze@FreeBSD.org
Subject: Re: cvs commit: ports/audio/faac/files patch-gcc
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Oct 2004 15:42:06 -0000

On Sat, 30 Oct 2004 10:05:59 -0400
Adam Weinberger <adamw@FreeBSD.org> wrote:
> > >   Modified files:
> > >     audio/faac/files     patch-gcc 
> > >   Log:
> > >   Add missing header to fix build of gstreamer-plugins on >5.x
> > 	Thank you.  But, please bump PORTREVISION in this case(for
> > 	effect to other ports, such as a significant change).
> >> end of "Re: cvs commit: ports/audio/faac/files patch-gcc" from Norikatsu Shigemura <<
> Why? If gst-p wouldn't build before on >5.X, why force 4.X users to
> rebuild faac to fix a problem they didn't have? It was on my suggestion
> that he didn't bump PORTREVISION, btw.

	If this fix only for faac-self, I don't say that.

	Please note, this fix causes that *gst-p* can build
	on >5.x.  In my environment, I already updated
	faac before this fix. I was in trouble.  But I noticed
	this commit.  If I din't update faac *manually*, I
	couldn't update gst-p.

	Why not *automatically*? To not rebuild on 4.x users.
	Humm.  Don't worry about trifles.  If faac isn't
	bumped PORTREVISION, update /usr/ports/UPDATING.  Or
	*anyone* can't notice how to fix build error problem
	on gst-p, *officially*.