From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jun 30 09:40:10 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DDA2D1065676 for ; Sat, 30 Jun 2012 09:40:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9D4278FC16 for ; Sat, 30 Jun 2012 09:40:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5U9eAPO085498 for ; Sat, 30 Jun 2012 09:40:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5U9eAqd085497; Sat, 30 Jun 2012 09:40:10 GMT (envelope-from gnats) Resent-Date: Sat, 30 Jun 2012 09:40:10 GMT Resent-Message-Id: <201206300940.q5U9eAqd085497@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Thomas Eberhardt Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 467BB106564A for ; Sat, 30 Jun 2012 09:31:18 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 30E458FC12 for ; Sat, 30 Jun 2012 09:31:18 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q5U9VH91080556 for ; Sat, 30 Jun 2012 09:31:17 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q5U9VH21080555; Sat, 30 Jun 2012 09:31:17 GMT (envelope-from nobody) Message-Id: <201206300931.q5U9VH21080555@red.freebsd.org> Date: Sat, 30 Jun 2012 09:31:17 GMT From: Thomas Eberhardt To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/169565: [patch] emulators/virtualbox-ose-kmod vboxnetadp kernel panic on unload X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jun 2012 09:40:11 -0000 >Number: 169565 >Category: ports >Synopsis: [patch] emulators/virtualbox-ose-kmod vboxnetadp kernel panic on unload >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Jun 30 09:40:10 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Thomas Eberhardt >Release: FreeBSD 9.0-STABLE amd64 >Organization: >Environment: FreeBSD clarence.ocp.lan 9.0-STABLE FreeBSD 9.0-STABLE #0 r237835M: Sat Jun 30 10:51:44 CEST 2012 thomas@clarence.ocp.lan:/usr/obj/usr/src/sys/CLARENCE amd64 >Description: I'm getting consistent kernel panics on unload of vboxnetadp. Started at around beginning of May 2012. >How-To-Repeat: kldload vboxnetadp kldunload vboxnetadp >Fix: Looking at patch-src-VBox-HostDrivers-VBoxNetAdp-freebsd-VBoxNetAdp-freebsd.c in the port, i found something fishy: @@ -286,7 +304,9 @@ void vboxNetAdpOsDestroy(PVBOXNETADP pTh { struct ifnet *ifp; + VBOXCURVNET_SET(ifp->if_vnet); ifp = pThis->u.s.ifp; ether_ifdetach(ifp); if_free(ifp); + VBOXCURVNET_RESTORE(); } looks like ifp is being used uninitialized. I changed this part of the patch to: @@ -286,7 +304,8 @@ void vboxNetAdpOsDestroy(PVBOXNETADP pTh { - struct ifnet *ifp; + struct ifnet *ifp = pThis->u.s.ifp; - ifp = pThis->u.s.ifp; + VBOXCURVNET_SET(ifp->if_vnet); ether_ifdetach(ifp); if_free(ifp); + VBOXCURVNET_RESTORE(); } After this change the kernel panics stopped. >Release-Note: >Audit-Trail: >Unformatted: