From owner-freebsd-ports@FreeBSD.ORG Mon Dec 29 12:53:21 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3A8881065672 for ; Mon, 29 Dec 2008 12:53:21 +0000 (UTC) (envelope-from tingox@gmail.com) Received: from mail-bw0-f19.google.com (mail-bw0-f19.google.com [209.85.218.19]) by mx1.freebsd.org (Postfix) with ESMTP id 717AB8FC18 for ; Mon, 29 Dec 2008 12:53:20 +0000 (UTC) (envelope-from tingox@gmail.com) Received: by bwz12 with SMTP id 12so12737775bwz.19 for ; Mon, 29 Dec 2008 04:53:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=U+2k+KrO9g20ldqHfVgLfvpzSpXQMvJYpQN+O90SqtE=; b=E/HSTu18veMH0jDF3/t90tNx58ljL9a8b408nPKm/ii/6m/LKPFgs919Ki6t89EOlm uK68hhZbYvtaMiW99fNG9ChSNxlpErtRhhwE6FZZiY3KHbX+FZVfxSeFrMgA/LQlRYHC nb2Eb3rYnDRFhZ/aMUtohzr1BFy3qyc1DXWPA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=rEH9OQ2H02HTJtKTqhuu+Wc5LjLLRj62+Mw3GleBhGf1rhFEcGFbrA81C1m2xoKjIt wO7nmMNJ6MWVh5uYPDFwddxJDm+iJZWbtGdcO9g+iAM/e9B3lztY4Mg0eUVEW8VX1pQM rfZwpO5KUALEuRG1dak0PBeoVrt2tFgkjMRJU= Received: by 10.223.109.200 with SMTP id k8mr9845675fap.44.1230555198793; Mon, 29 Dec 2008 04:53:18 -0800 (PST) Received: by 10.223.115.202 with HTTP; Mon, 29 Dec 2008 04:53:18 -0800 (PST) Message-ID: Date: Mon, 29 Dec 2008 13:53:18 +0100 From: "Torfinn Ingolfsen" To: freebsd-ports@freebsd.org In-Reply-To: <20080823020518.GA75067@hades.panopticon> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080821105506.GA25154@wep4017.physik.uni-wuerzburg.de> <20080822125845.GB4663@hades.panopticon> <20080822221339.GH1421@hades.panopticon> <20080823020518.GA75067@hades.panopticon> Subject: Re: amule 2 port - trying an upgrade X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Dec 2008 12:53:21 -0000 Hello, Real life got in the way, and my amule2 porting efforts had to be put on hold. Buttime waits for no man, and now aMule 2.2.3 has been released. So I wil restart my efforts with the newest version. On Sat, Aug 23, 2008 at 3:05 AM, Dmitry Marakasov wrote: > No, they are automake's macro language and are expanded my automake > to produce Makefile.in. Since the final product is Makefiles, shell > stuff is possible there. > > However, you shouldn't modify .am stuff in this case, as automake > is not executed in the build process. The only things you're to > modify are configure and Makefile.in files. > You can, of course, modify .am stuff instead and call automake/autoconf > to regenerate stuff (via USE_AUTOTOOLS), but that's only needed in > extreme cases. Thanks for explaining this. > PORTREVISION should be removed when PORTVERSION is bumped Good to know. >> +USE_XORG= x11 > Not actually needed, as the port uses wx which assumes x11. OK, I'll remove it then. >> +USE_GETTEXT= yes > Using gettext conditionally like before no longer work? I don't really know. What exactly do we gain by using gettext conditionally? >> -CONFIGURE_TARGET=--build=${MACHINE_ARCH}-portbld-freebsd${OSREL} >> + >> +CONFIGURE_TARGET= --build=${MACHINE_ARCH}-portbld-freebsd${OSREL} > Please remove, this is now handled automatically. Ok, will do. >> CONFIGURE_ARGS= --disable-debug \ >> + --mandir=${MANPREFIX}/man \ > Not needed, --mandir is appended to CONFIGURE_ARGS by default I had noted that, but forhot tom remove that part. >> -.if !defined(WITHOUT_OPTIMIZE) >> +.if defined(WITH_OPTIMIZE) > No, checking WITHOUT_OPTIMIZE is correct. You should check > counter-default values for options, i.e. check WITH_FOO if FOO is > off by default, and WITHOUT_FOO if FOO is on by default. Same for > other checks. Is this documented in the Porters Handbook anywhere? If so, I must have missed it. > There are automatic ways to handle docs, so you don't need to change > plist on every update. > > One way is to define DOCSDIR in the Makefile: > DOCSDIR= ${PREFIX}/share/doc/aMule-${PORTVERSION} > > and use %%DOCSDIR%% instead of share/doc/aMule-2.2.2 in the plist. > > Another way is to add PORTDOCS=* to Makefile in addition to DOCSDIR, > and remove doc files from plist completely - they'll be added > automatically on install. I will look into this. Your comments are valuable - thank you. -- Regards, Torfinn Ingolfsen, Norway