From owner-freebsd-testing@FreeBSD.ORG Thu Jan 23 21:45:59 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 780C4A8A; Thu, 23 Jan 2014 21:45:59 +0000 (UTC) Received: from mail-pd0-x234.google.com (mail-pd0-x234.google.com [IPv6:2607:f8b0:400e:c02::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3A4431F72; Thu, 23 Jan 2014 21:45:59 +0000 (UTC) Received: by mail-pd0-f180.google.com with SMTP id x10so2302123pdj.39 for ; Thu, 23 Jan 2014 13:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=5C5lo2Xm1rwkAnT9Tgqkj9S+Lv354sDjJr4fuhxWy4Y=; b=nxjk+a6ZC8vRHaQ6KxrPkGD0NOuDFEu0yLzfMZCrV/nBh/+0zfjKcEAFAiHrSmcdLP bY/XPIittXp2sIPlPPKDUx7TWn77WmqkjJSaIp1RDD+33GmZCbIq6ZpMI6Cm/9qedE0j nKh0RTx8hZDMSPMvqTaz39Qsb4Qc12bWglqVusoKqPyEvvk3+rSktOl1x/JrvjV3YVWd x8RlzrlNJDA/wt3lzviWWU7zEzWmBI2EtwW5HN5nDErcBI0FiRgh/+SYYCyqAyOuqyxS hmpG9/jwnburwik+aTsyyC7wmMmJNdnLdK5Hc2uJYhX52JkCAn4bFP/FPHm0O/yNOQnL JfZg== X-Received: by 10.66.150.69 with SMTP id ug5mr10460513pab.55.1390513558804; Thu, 23 Jan 2014 13:45:58 -0800 (PST) Received: from fuji.zcorp.zonarsystems.com ([64.14.143.130]) by mx.google.com with ESMTPSA id da3sm41395250pbc.30.2014.01.23.13.45.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 13:45:58 -0800 (PST) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Makefile.inc1.patch From: Garrett Cooper In-Reply-To: <20140123214335.DD4255807E@chaos.jnpr.net> Date: Thu, 23 Jan 2014 13:45:55 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <949DAC82-A5AA-42FE-81A5-385A84718166@gmail.com> References: <4A3E3984-73D3-4441-97A7-D58679EFF978@gmail.com> <9775878D-91AB-4BE4-ADFA-32D8DB582AA6@gmail.com> <4DB8E40F-6D7B-41A9-A0FA-B2E241E9A180@gmail.com> <20140123214335.DD4255807E@chaos.jnpr.net> To: "Simon J. Gerraty" X-Mailer: Apple Mail (2.1827) Cc: "freebsd-testing@freebsd.org" , Brooks Davis X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 21:45:59 -0000 On Jan 23, 2014, at 1:43 PM, Simon J. Gerraty wrote: >=20 > On Thu, 23 Jan 2014 13:23:57 -0800, Garrett Cooper writes: >> NO_TESTS forces WITHOUT_TESTS to be set. So, if I set NO_TESTS =3D= >> in the various build steps it will force ATF to not be built. For = that =3D >> reason (and that reason alone) I reintroduced WITH_ATF just for =3D >> Makefile.inc1 (but you could replace it with something else like =3D >> WITH_ATF_LIBS, etc, if the naming is too confusing). >=20 > Is there a need to have a knob at all? To build atf libs I mean. For right now yeah, it=92s distinguished that way :/.. but it = seems lightweight enough (2 mins compile time?) to include in standard = builds. Maybe have a well-documented NO_ATF_LIBS knob for those that = need the extra compile time? Thanks! -Garrett=