From owner-p4-projects@FreeBSD.ORG Sat May 30 12:47:48 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 5A0C1106566C; Sat, 30 May 2009 12:47:48 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 190A91065674 for ; Sat, 30 May 2009 12:47:48 +0000 (UTC) (envelope-from ccna.syl@gmail.com) Received: from yw-out-2324.google.com (yw-out-2324.google.com [74.125.46.28]) by mx1.freebsd.org (Postfix) with ESMTP id C6D498FC18 for ; Sat, 30 May 2009 12:47:47 +0000 (UTC) (envelope-from ccna.syl@gmail.com) Received: by yw-out-2324.google.com with SMTP id 9so3556368ywe.13 for ; Sat, 30 May 2009 05:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=WyM2qlZ7yhgSnAt0gOeVsh6kjIAKa19Kdg4/XuY2gjc=; b=xz3etepB6QdsfQvT4TNRz4Ra+VtfMrZR88J7z7DlDIVEKrEpraG+53Oi6yohtdMebg OLG6ntpr9qeTZtzPwBw4u/rxfkoWMADON9mrIrTSyWH3kyk4zQv38elXVpXbOL6ZOS8C 0VUxqgeZpnpCcC8CAm6aYzjMu/WejnXdp8Gw0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=I5e1/Kp3PRLrkLKP4TYXtNgJsMcF3x5AGBypO2G6CfoH/zreZNs+AqneW61Cm4rAkA Cu/86gu6uilpJLStk6oaZDkMZJeNaa7YW1m6QWWmQE9vt5Ab48GDq1b8L2MmGNNQ1Dtv 0qke4YZr2ZPJHMGgPSzQD+2SYfM2OWXJCXDWc= MIME-Version: 1.0 Received: by 10.231.38.198 with SMTP id c6mr1126943ibe.21.1243687667069; Sat, 30 May 2009 05:47:47 -0700 (PDT) In-Reply-To: <200905301428.54367.hselasky@c2i.net> References: <200905301128.n4UBSGad022347@repoman.freebsd.org> <200905301428.54367.hselasky@c2i.net> From: Sylvestre Gallon Date: Sat, 30 May 2009 14:47:27 +0200 Message-ID: <164b4c9c0905300547q6036b6dax710c1bce47599852@mail.gmail.com> To: Hans Petter Selasky Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Perforce Change Reviews Subject: Re: PERFORCE change 163077 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2009 12:47:49 -0000 On Sat, May 30, 2009 at 2:28 PM, Hans Petter Selasky wro= te: > On Saturday 30 May 2009, Sylvestre Gallon wrote: >> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0ret =3D libusb20_dev_proce= ss(devh->os_priv); >> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (ret =3D=3D 0 || LIBUSB= 20_ERROR_NO_DEVICE) > > ret =3D=3D LIBUSB20_ERROR_NO_DEVICE > > One note: > > libusb20 is not thread safe. So you might need an additional lock for tha= t, > I.E. when you call libusb20_dev_process() and libusb20_tr_submit()++ must= be > atomic. If this cannot be solved in libusb10, I will do something. > > --HPS > Ok, I will add a mutex for libusb20. Cheers, --=20 Sylvestre Gallon (http://devsyl.blogspot.com) Fifth Grade Student @ Epitech & Researcher @ LSE R&D @ Rathaxes (http://www.rathaxes.org)