From owner-p4-projects@FreeBSD.ORG  Sat Feb  2 12:13:02 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id AE56816A41B; Sat,  2 Feb 2008 12:13:02 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5B3B816A418;
	Sat,  2 Feb 2008 12:13:02 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 4832D13C465;
	Sat,  2 Feb 2008 12:13:02 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 0C7D71A4D83; Sat,  2 Feb 2008 04:13:02 -0800 (PST)
Date: Sat, 2 Feb 2008 04:13:02 -0800
From: Alfred Perlstein <alfred@freebsd.org>
To: Hans Petter Selasky <hselasky@freebsd.org>
Message-ID: <20080202121301.GY99258@elvis.mu.org>
References: <200712020001.lB201XbN000811@repoman.freebsd.org>
	<20080202022234.GR99258@elvis.mu.org>
	<200802020818.57037.hselasky@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200802020818.57037.hselasky@freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 129920 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Feb 2008 12:13:03 -0000

* Hans Petter Selasky <hselasky@freebsd.org> [080201 23:18] wrote:
> On Saturday 02 February 2008, Alfred Perlstein wrote:
> > This change makes very little sense.  If xfer->frbuffers is a bare
> > pointer, then why add 0 to it?  Just pass xfer->frbuffers or use a
> > macro that explains what you are doing.
> >
> 
> I can change those to a plain "xfer->frlengths". It was just a reminder for 
> me, because some places we use "xfer->frlengths + 1" and "xfer->frbuffers + 
> 1".
> 
> I will write a script that converts all of those.

What does '+ 1' mean?  Is it something special like a channel or something?

If so it should be a macro that's more descriptive.

-- 
- Alfred Perlstein