Date: Wed, 3 Jun 2015 11:23:12 -0400 From: "Philip M. Gollucci" <pgollucci@p6m7g8.com> To: John Marino <marino@freebsd.org> Cc: "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r388391 - head/Mk Message-ID: <CACM2dAbffxF1bA-UrgXjHpyZ_nmD7FVtPBTF%2BeifZthp=F4kgA@mail.gmail.com> In-Reply-To: <201506022117.t52LH1Mk057541@svn.freebsd.org> References: <201506022117.t52LH1Mk057541@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
You're my hero! On Tue, Jun 2, 2015 at 5:17 PM, John Marino <marino@freebsd.org> wrote: > Author: marino > Date: Tue Jun 2 21:17:00 2015 > New Revision: 388391 > URL: https://svnweb.freebsd.org/changeset/ports/388391 > > Log: > bsd.port.mk: Implement BROKEN_${OPSYS} and BROKEN_${OPSYS}_${OSREL:R} > > Examples of use: > * BROKEN_FreeBSD= does not link > * BROKEN_DragonFly= requires later jail > * BROKEN_FreeBSD_8= long type-name is invalid > > The latter example could replace something like: > > .include <bsd.port.pre.mk> > .if ${OPSYS} == FreeBSD && ${OSVERSION} <= 900000 > BROKEN= long type-name is invalid > .endif > > Differential Revision: https://reviews.freebsd.org/D2207 > Reviewed by: portmgr > Approved by: portmgr (mat) > > Modified: > head/Mk/bsd.port.mk > > Modified: head/Mk/bsd.port.mk > > ============================================================================== > --- head/Mk/bsd.port.mk Tue Jun 2 21:06:08 2015 (r388390) > +++ head/Mk/bsd.port.mk Tue Jun 2 21:17:00 2015 (r388391) > @@ -175,9 +175,16 @@ FreeBSD_MAINTAINER= portmgr@FreeBSD.org > # BROKEN - Port is believed to be broken. Package builds > can > # still be attempted using TRYBROKEN to > test this > # assumption. > -# BROKEN_${ARCH} Port is believed to be broken on ${ARCH}. Package builds > -# can still be attempted using TRYBROKEN > to test this > -# assumption. > +# BROKEN_${ARCH} - Port is believed to be broken on ${ARCH}. Package > builds > +# can still be attempted using TRYBROKEN to > +# test this assumption. > +# BROKEN_${OPSYS} - Port is believed to be broken on ${OPSYS}. Package > builds > +# can still be attempted using TRYBROKEN to > +# test this assumption. > +# BROKEN_${OPSYS}_${OSREL:R} - Port is believed to be broken on a single > +# release of ${OPSYS}, e.g BROKEN_FreeBSD_8 > +# would affect all point releases of > FreeBSD 8 > +# unless TRYBROKEN is also set. > # DEPRECATED - Port is deprecated to install. Advisory only. > # EXPIRATION_DATE > # - If DEPRECATED is set, determines a date > when > @@ -2820,6 +2827,14 @@ IGNORE= is marked as broken: ${BROKEN} > .if !defined(TRYBROKEN) > IGNORE= is marked as broken on ${ARCH}: ${BROKEN_${ARCH}} > .endif > +.elif defined(BROKEN_${OPSYS}_${OSREL:R}) > +.if !defined(TRYBROKEN) > +IGNORE= is marked as broken on ${OPSYS} ${OSREL}: > ${BROKEN_${OPSYS}_${OSREL:R}} > +.endif > +.elif defined(BROKEN_${OPSYS}) > +.if !defined(TRYBROKEN) > +IGNORE= is marked as broken on ${OPSYS}: ${BROKEN_${OPSYS}} > +.endif > .elif defined(FORBIDDEN) > IGNORE= is forbidden: ${FORBIDDEN} > .endif > > -- --------------------------------------------------------------------------------- Curb: Your ride is here 4096R/D21D2752 <http://pgp.mit.edu/pks/lookup?op=get&search=0xF699A450D21D2752> ECDF B597 B54B 7F92 753E E0EA F699 A450 D21D 2752 Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 Member, Apache Software Foundation Committer, FreeBSD Foundation Consultant, P6M7G8 Inc. Sr. Director IT Operations, Curb What doesn't kill us can only make us stronger; Except it almost kills you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACM2dAbffxF1bA-UrgXjHpyZ_nmD7FVtPBTF%2BeifZthp=F4kgA>