From owner-freebsd-stable@FreeBSD.ORG Tue Apr 23 13:49:55 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 32D0690E for ; Tue, 23 Apr 2013 13:49:55 +0000 (UTC) (envelope-from jdc@koitsu.org) Received: from qmta01.emeryville.ca.mail.comcast.net (qmta01.emeryville.ca.mail.comcast.net [IPv6:2001:558:fe2d:43:76:96:30:16]) by mx1.freebsd.org (Postfix) with ESMTP id 15317142A for ; Tue, 23 Apr 2013 13:49:55 +0000 (UTC) Received: from omta24.emeryville.ca.mail.comcast.net ([76.96.30.92]) by qmta01.emeryville.ca.mail.comcast.net with comcast id TRj91l00A1zF43QA1RpuH8; Tue, 23 Apr 2013 13:49:54 +0000 Received: from koitsu.strangled.net ([67.180.84.87]) by omta24.emeryville.ca.mail.comcast.net with comcast id TRpt1l0101t3BNj8kRpt8c; Tue, 23 Apr 2013 13:49:54 +0000 Received: by icarus.home.lan (Postfix, from userid 1000) id 9AFBC73A33; Tue, 23 Apr 2013 06:49:53 -0700 (PDT) Date: Tue, 23 Apr 2013 06:49:53 -0700 From: Jeremy Chadwick To: Tom Evans Subject: Re: ada(4) and ahci(4) quirk printing Message-ID: <20130423134953.GA64010@icarus.home.lan> References: <20130422051452.GA2148@icarus.home.lan> <51763BF9.2000506@FreeBSD.org> <20130423092602.GA58831@icarus.home.lan> <51765466.4040209@FreeBSD.org> <4D28DBAE46424C268AA22FCDD8657946@multiplay.co.uk> <20130423114722.GA61919@icarus.home.lan> <20130423125144.GA62949@icarus.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1366724994; bh=rLvOx0dnusiBbfeO6QsVdKQadscQPlOg2ieVkHsm50o=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=qwFsYBflso+CvOU7ETePouL+dGG8/d2/ClT6zBEq3dHWTRjVK3IUmcEODz/FpFaPK Ig5D48DZceVrqWfOIAojyYzQqcUhA0ir06JQOc+TptjehVWCchfBQ+YRTebK5A7khr 7J2y2vWtpIB+aG6VGjlVybgqRFo5x+IS5SmJzrJL26Tr6ywNugC77LhHJRWV3uySei 33gADZTKd7eKLqte8cVHlb+2yCeNq/Cn2w4QeY49S05qih7yCh0WOhFoYfSACH0zdg l4O4RWfK/ikstbV5l5HkfW0fzobwHpK2FHbOFRnw8gUKYVfoZjjIqhL4n5Q+NRCy1u VdGGhqp6q0SBg== Cc: freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2013 13:49:55 -0000 On Tue, Apr 23, 2013 at 02:15:31PM +0100, Tom Evans wrote: > On Tue, Apr 23, 2013 at 1:51 PM, Jeremy Chadwick wrote: > > On Tue, Apr 23, 2013 at 01:20:31PM +0100, Steven Hartland wrote: > >> >4) camcontrol wouldn't address the need/interest for ahci(4) quirks to > >> >be made available. > >> > >> Why? > > > > Because camcontrol is for CAM. ahci(4) is not part of CAM. The last > > place I'd look for "poking at AHCI" (as in *actual AHCI*) is camcontrol. > > > > This is one of the reasons sysctl exists -- it's a sort of "covers > > everything" tree, on a per-device basis. > > Just on this point, these quirks aren't actually quirks of ahci(4) are > they? They are quirks of the disks that are attached to ahci(4), and > presumably should apply regardless of whether the disk in question is > hooked up to ahci(4), siis(4) or even mps(4). There are two patches: one prints ada(4) (disk) quirks, the other prints ahci(4) (controller) quirks. These are two separate/unrelated things. > To my mind, this means the quirks should belong to da(4), or at the > very least ada(4). ada(4) and da(4) are both manipulated by CAM, so > having this in camcontrol seems logical to me. To clarify, my mind is > completely oblivious of how all this is implemented in software, so > perhaps my mind needs to be changed rather than the code! -- | Jeremy Chadwick jdc@koitsu.org | | UNIX Systems Administrator http://jdc.koitsu.org/ | | Mountain View, CA, US | | Making life hard for others since 1977. PGP 4BD6C0CB |