From nobody Fri Jul 28 04:31:29 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RBvpy6jFMz4p2K0; Fri, 28 Jul 2023 04:31:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RBvpn5rRFz47BM; Fri, 28 Jul 2023 04:31:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690518689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jk+NS8IIEvK0446WzLubOqTR9+eTWwFLTP42wFBdxK0=; b=uoButdqPD3EuAql2n2MqvErv4Mt/JmJ7TpNPJ90ydFKMGFwqf4/4dB0+o12n3IIm+mYkDy ujRTdMjCBzc/ZuGawOI5DfrHk9K+AkVDsIBiL936tnMtgfp7knYf9v7f59BbHVE3cWRFlK TLSZzjM6UbRLE8Ar0EUbdRQlFCeupr0gGLGQ4BYPNmHhzLISpAuXq3F6iCqfGUcZqDl/LF bA+KMBxUacG4hI0+AnlLLvMEXSGiFYYeBn+tpH++eLdsUXhrG/K/2CNpjGZZKLzB0m3MRh YUcDyBNAOJoOFIbNh6TpazO4F3lsnrSMSAB4STNbI38BccfQEX5W38p0h/WzUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690518689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jk+NS8IIEvK0446WzLubOqTR9+eTWwFLTP42wFBdxK0=; b=DPYp1550i5lVQ5MWv9ue+wZML+mYn9mbM6ltXcL9Z4LB6PefA9W9MiCsnsNq0z7y47Lnl1 Zg8Q8s+iVN4zpDF1OtLP8pC4Ufgg/sau/NG9FjwNPWn+Cw3wn/qZo6EJk+tVTVbb2GlKIW 9VuHmzprXTtFgEgIPOx1GiDUqPbg3eUFZfNGvhl+B2ntAJpyE0o6NWLWKTSkM4E7KmqZyS V8Cno8VEBbGBROWbFt/cUOBuS3yfQgkmpZ4+L1wFYs7JB8JwHavWuvDv7e3KB1f//jrfV4 ii10NXiB6VkqIrvYYw/4TMkz7+Xx5epGm5L+NWYVr2C64P69dRjLuTU3VQw/Xg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690518689; a=rsa-sha256; cv=none; b=uPdoa7MtrcjLXJsD2sy5EBgSyeNr3OAIINLCwAooBqEZ5qFE++Xap6AIRxgLzhKafqNEJm XzWG0O0kS3kq1aVV3KUhbpAMc9y7Rie7RX8rVL+nzggms2YuXczoPUI8s9cUF348eglF20 Xr9oHDwxdjzZiS6Ul6/G8gmkyuMzpZbntPuCf1gLsRVjqJ8yFQP3RXR1vyQ4M7RE+gHa3Y EGzaE28wH7Cgq5bVYigjkz7LH/Z97X+uo/TbjtdWvtUnw+p1FnheHPQ2MefQG6Fv62VS3q foWcWUNl3V3V+W55eKzM3itzvqXmSoMmsipiEahCIcG9NBu6NYnkjWv36lZeYw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RBvpn4mF8zcsc; Fri, 28 Jul 2023 04:31:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 36S4VTG0012089; Fri, 28 Jul 2023 04:31:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 36S4VTuV012088; Fri, 28 Jul 2023 04:31:29 GMT (envelope-from git) Date: Fri, 28 Jul 2023 04:31:29 GMT Message-Id: <202307280431.36S4VTuV012088@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 7872131605f6 - main - cam: Fail 2/0 asc/ascq return code List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7872131605f65d3e1cc651ba7113a9214013787a Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=7872131605f65d3e1cc651ba7113a9214013787a commit 7872131605f65d3e1cc651ba7113a9214013787a Author: Warner Losh AuthorDate: 2023-07-27 22:05:29 +0000 Commit: Warner Losh CommitDate: 2023-07-28 04:28:01 +0000 cam: Fail 2/0 asc/ascq return code This asc/ascq code 2/0 ("No seek complete") is a fatal error on modern drives indicating a sensor failure. One of our vendors noticed we retried 2/0 so many times in their failure analysis and asked why (no other OS else does). They've indicated that this failures means the track couldn't be located (something that's not going to change, except if the environment changes significantly, which won't happen on a timescale useful to retries). Sponsored by: Netflix --- sys/cam/scsi/scsi_all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/cam/scsi/scsi_all.c b/sys/cam/scsi/scsi_all.c index d7b0a208c10d..e0079dd8ff88 100644 --- a/sys/cam/scsi/scsi_all.c +++ b/sys/cam/scsi/scsi_all.c @@ -1082,7 +1082,7 @@ static struct asc_table_entry asc_table[] = { { SST(0x01, 0x00, SS_RDEF, "No index/sector signal") }, /* D WRO BK */ - { SST(0x02, 0x00, SS_RDEF, + { SST(0x02, 0x00, SS_FATAL | EIO, "No seek complete") }, /* DTL W O BK */ { SST(0x03, 0x00, SS_RDEF,