From owner-freebsd-current@FreeBSD.ORG Tue Jul 23 11:28:35 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 36827A51 for ; Tue, 23 Jul 2013 11:28:35 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A09BA28C1 for ; Tue, 23 Jul 2013 11:28:34 +0000 (UTC) Received: (qmail 46612 invoked from network); 23 Jul 2013 12:16:50 -0000 Received: from unknown (HELO [62.48.0.94]) ([62.48.0.94]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 23 Jul 2013 12:16:50 -0000 Message-ID: <51EE68D8.9020603@freebsd.org> Date: Tue, 23 Jul 2013 13:28:24 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Andrey V. Elsukov" Subject: Re: IPSEC crashes after r253088 References: <20130721054323.915f865769e6042c7dc62d08@tackymt.homeip.net> <51EE309D.2030106@FreeBSD.org> In-Reply-To: <51EE309D.2030106@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: George Neville-Neil , Taku YAMAMOTO , freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jul 2013 11:28:35 -0000 On 23.07.2013 09:28, Andrey V. Elsukov wrote: > On 21.07.2013 00:43, Taku YAMAMOTO wrote: >> After r253088, systems with IPSEC and KSTACK_PAGES < 4 crashes on >> booting into multi-user mode. >> >> The crash is due to sysctl -a in /etc/rc.d/initrandom ended up with >> kernel stack overflow. > >> where type is struct ipsecstat which is 12560 bytes of size (larger than >> 3 pages) of size when processing net.inet.ipsec.ipsecstats. > > Hi, > > Only few fields of struct ipsecstat is used, the rest fields are never > updated. We can split it to several structures, or just remove unused > fields. What is better? Not storing it on the stack? -- Andre