From owner-freebsd-net@FreeBSD.ORG Wed Oct 21 19:40:21 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E8CC1065692 for ; Wed, 21 Oct 2009 19:40:21 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from gv-out-0910.google.com (gv-out-0910.google.com [216.239.58.185]) by mx1.freebsd.org (Postfix) with ESMTP id CEF058FC24 for ; Wed, 21 Oct 2009 19:40:20 +0000 (UTC) Received: by gv-out-0910.google.com with SMTP id n29so885065gve.39 for ; Wed, 21 Oct 2009 12:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=e6cMQPypS/b8V0E0AtmxFvXsvFIDikJUratvLzqRYCY=; b=BsJgAQr59URtErKZ4vu0hvNzAaIxbxQ3eNgtNub+WQ+WufaL+sMGhHQtANE9+v2Uoz Px8Lo9I8fdll5K/x79mFVbl9z6OAjUk1LI34Lg2x+rTp05P2cB3qN4RJcuVxjTR++hgW jtDK3p1D2AG2X5qvsz0TjryDba8m0qBDpyH/0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=OZi1I6UA9vsbsn3cbds8Zg9uqz2L9/tICus7ZVTr26bJyxCT9frdQvUinSFODRZs/R bb58ZZVhq1BGd1blFTNPUUtcxqIPYGyP/dzzaYrrXvLDcKPYYTUzP26/99X5WinV28rY 2PW7sW0+2oHI/WCnE8/RG+DLp/lWtd4zw9hVs= Received: by 10.102.222.8 with SMTP id u8mr3641966mug.96.1256154019759; Wed, 21 Oct 2009 12:40:19 -0700 (PDT) Received: from mac-mini.lan (bl11-0-248.dsl.telepac.pt [85.244.0.248]) by mx.google.com with ESMTPS id 12sm50077muq.18.2009.10.21.12.40.18 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 21 Oct 2009 12:40:18 -0700 (PDT) Sender: Rui Paulo Mime-Version: 1.0 (Apple Message framework v1076) Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes From: Rui Paulo In-Reply-To: <200910211012.15474.bschmidt@techwires.net> Date: Wed, 21 Oct 2009 20:40:16 +0100 Content-Transfer-Encoding: 7bit Message-Id: References: <20091009170839.142800@gmx.net> <200910210833.44121.bschmidt@techwires.net> <25ff90d60910210029t5f8f67d0nd17b537ecaacdee9@mail.gmail.com> <200910211012.15474.bschmidt@techwires.net> To: Bernhard Schmidt X-Mailer: Apple Mail (2.1076) Cc: freebsd-net@freebsd.org, David Horn Subject: Re: Intel WiFi 5100/5300 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2009 19:40:21 -0000 On 21 Oct 2009, at 09:12, Bernhard Schmidt wrote: > On Wednesday 21 October 2009 09:29:13 David Horn wrote: >>>> The only new issue I have found so far is that I must manually load >>>> iwnfw.ko before loading if_iwn.ko (the module depend used to work >>>> on >>>> the in-tree driver) >>> >>> Hmm.. that is probably related to the rename of the firmware image, >>> iwnfw-5000 instead of iwnfw. Is MODULE_DEPEND(iwn, iwnfw, 1, 1, >>> 1); an >>> option there? >> >> MODULE_DEPEND(iwn, iwnfw_fw, 1, 1, 1) >> >> added to if_iwn.c fixes it nicely (note: iwnfw_fw not just iwnfw). >> It >> turns out the original driver loaded the iwnfw.ko module as part of >> firmware_get() since the firmware module name matched the first >> firmware image name (see firmware.h comments). Looking at the other >> drivers, the other option is to break up the firmware images into >> unique kernel modules (e.g. ral or iwi), and allow firmware_get() to >> do the load. I would think that this would reduce kernel memory >> usage >> as well (several individual firmware modules vs all firmware images >> in >> one module). Just a thought. > > Any "offical" opinions on that one? Should we break iwnfw up into > individual > modules? I believe so. Thanks for your work. I hope this can be in HEAD soon. Regards, -- Rui Paulo