From owner-freebsd-arch Sun Feb 25 13:22: 0 2001 Delivered-To: freebsd-arch@freebsd.org Received: from obsecurity.dyndns.org (adsl-63-207-60-10.dsl.lsan03.pacbell.net [63.207.60.10]) by hub.freebsd.org (Postfix) with ESMTP id 359FD37B491; Sun, 25 Feb 2001 13:21:53 -0800 (PST) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id ACEFB66F83; Sun, 25 Feb 2001 13:21:52 -0800 (PST) Date: Sun, 25 Feb 2001 13:21:52 -0800 From: Kris Kennaway To: arch@FreeBSD.ORG Cc: "Andrey A. Chernov" , "Jacques A. Vidrine" , Matt Dillon , Bruce Evans , Kris Kennaway , Robert Watson , Nick Sayer , cvs-all@FreeBSD.ORG Subject: Re: rand.c patch for review (was: Re: cvs commit: ports/astro/xglobe/files patch-random) Message-ID: <20010225132152.A39554@mollari.cthul.hu> Reply-To: arch@freebsd.org References: <200102250900.f1P90Qc12868@earth.backplane.com> <20010225092416.A46959@hamlet.nectar.com> <20010225185535.A55782@nagual.pp.ru> <20010225191316.A56093@nagual.pp.ru> <20010225193409.A56351@nagual.pp.ru> <20010225131002.A38192@mollari.cthul.hu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="gBBFr7Ir9EOA20Yy" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010225131002.A38192@mollari.cthul.hu>; from kris@obsecurity.org on Sun, Feb 25, 2001 at 01:10:02PM -0800 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --gBBFr7Ir9EOA20Yy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 25, 2001 at 01:10:02PM -0800, Kris Kennaway wrote: > > Patch for review: >=20 > Can't you just wrap it around random() and srandom() instead of > duplicating the code? Nevermind, I read the followup about needing to have independent state. I think you should duplicate the rest of the random() and srandom() stuff, not just good_rand() -- random.c does more work to seed things, for example, which I'd feel better about. Also, document in rand.c and random.c that they should be kept in sync modulo the missing srandomdev() code. Kris --gBBFr7Ir9EOA20Yy Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE6mXdwWry0BWjoQKURAtRWAJ0dogbT2Lfgrj9tWMvR/MWgqP/vXACfb+n/ RP0F5P0D1vSW83S7LOrC9g4= =/AME -----END PGP SIGNATURE----- --gBBFr7Ir9EOA20Yy-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message