From owner-freebsd-ports@FreeBSD.ORG Tue Jan 17 22:50:23 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1E10106566C for ; Tue, 17 Jan 2012 22:50:23 +0000 (UTC) (envelope-from kerndtr@kerndt.com) Received: from stubing.kerndt.com (stubing.kerndt.com [204.109.63.165]) by mx1.freebsd.org (Postfix) with ESMTP id 61F188FC14 for ; Tue, 17 Jan 2012 22:50:23 +0000 (UTC) Received: from captain (c-67-171-240-229.hsd1.or.comcast.net [67.171.240.229]) (authenticated bits=0) by stubing.kerndt.com (8.14.3/8.14.3) with ESMTP id q0HMGdnP087438 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Tue, 17 Jan 2012 14:16:40 -0800 (PST) (envelope-from kerndtr@kerndt.com) From: "Rickie Kerndt" To: Date: Tue, 17 Jan 2012 14:16:56 -0800 Message-ID: <000001ccd565$ba3ced30$2eb6c790$@com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0001_01CCD522.AC19AD30" X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AczVZblQ3iM6twbKThqJjsd1wratsQ== Content-Language: en-us Cc: Subject: mhonarc deprecated use of defined() X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2012 22:50:23 -0000 This is a multi-part message in MIME format. ------=_NextPart_000_0001_01CCD522.AC19AD30 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mhonarc when run with perl 10.14.2 complains about its deprecated use of defined(%a_hash). I've replaced these defined() where used (not many) as shown in the attached patch files. Is there any interest in updating the mhonarc port to fix this issue? Rickie Kerndt Eugene, OR kerndtr@kerndt.com ------=_NextPart_000_0001_01CCD522.AC19AD30 Content-Type: application/octet-stream; name="Makefile.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="Makefile.diff" --- Makefile.orig 2012-01-17 06:01:21.000000000 -0800=0A= +++ Makefile 2012-01-16 14:50:34.000000000 -0800=0A= @@ -7,6 +7,7 @@=0A= =0A= PORTNAME=3D mhonarc=0A= PORTVERSION=3D 2.6.18=0A= +PORTREVISION=3D 1=0A= CATEGORIES=3D www mail=0A= MASTER_SITES=3D http://www.mhonarc.org/release/MHonArc/tar/ \=0A= http://www.oac.uci.edu/indiv/ehood/tar/=0A= ------=_NextPart_000_0001_01CCD522.AC19AD30 Content-Type: application/octet-stream; name="patch-lib__mhamain.pl" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="patch-lib__mhamain.pl" --- ./lib/mhamain.pl.orig 2012-01-16 14:28:02.000000000 -0800=0A= +++ ./lib/mhamain.pl 2012-01-16 14:31:22.000000000 -0800=0A= @@ -1561,7 +1561,7 @@=0A= ## Create Index2MsgId if not defined=0A= ##=0A= sub defineIndex2MsgId {=0A= - if (!defined(%Index2MsgId)) {=0A= + if (!(%Index2MsgId)) {=0A= foreach (keys %MsgId) {=0A= $Index2MsgId{$MsgId{$_}} =3D $_;=0A= }=0A= ------=_NextPart_000_0001_01CCD522.AC19AD30 Content-Type: application/octet-stream; name="patch-lib__mhopt.pl" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="patch-lib__mhopt.pl" --- ./lib/mhopt.pl.orig 2012-01-16 14:32:41.000000000 -0800=0A= +++ ./lib/mhopt.pl 2012-01-16 14:33:10.000000000 -0800=0A= @@ -864,7 +864,7 @@=0A= ##=0A= sub update_data_2_1_to_later {=0A= # we can preserve filter arguments=0A= - if (defined(%main::MIMEFiltersArgs)) {=0A= + if (%main::MIMEFiltersArgs) {=0A= warn qq/ preserving MIMEARGS...\n/;=0A= %readmail::MIMEFiltersArgs =3D %main::MIMEFiltersArgs;=0A= $IsDefault{'MIMEARGS'} =3D 0;=0A= ------=_NextPart_000_0001_01CCD522.AC19AD30 Content-Type: application/octet-stream; name="patch-lib__readmail.pl" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="patch-lib__readmail.pl" --- ./lib/readmail.pl.orig 2012-01-16 14:33:30.000000000 -0800=0A= +++ ./lib/readmail.pl 2012-01-16 14:35:37.000000000 -0800=0A= @@ -117,9 +117,9 @@=0A= ## set to true.=0A= =0A= %MIMEDecoders =3D ()=0A= - unless defined(%MIMEDecoders);=0A= + unless (%MIMEDecoders);=0A= %MIMEDecodersSrc =3D ()=0A= - unless defined(%MIMEDecodersSrc);=0A= + unless (%MIMEDecodersSrc);=0A= =0A= ## - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - = - - -=0A= ## %MIMECharSetConverters is the associative array for storing = functions=0A= @@ -153,9 +153,9 @@=0A= ## string.=0A= =0A= %MIMECharSetConverters =3D ()=0A= - unless defined(%MIMECharSetConverters);=0A= + unless (%MIMECharSetConverters);=0A= %MIMECharSetConvertersSrc =3D ()=0A= - unless defined(%MIMECharSetConvertersSrc);=0A= + unless (%MIMECharSetConvertersSrc);=0A= =0A= ## - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - = - - -=0A= ## %MIMEFilters is the associative array for storing functions that=0A= @@ -180,9 +180,9 @@=0A= ## that all functions are defined before invoking MAILread_body.=0A= =0A= %MIMEFilters =3D ()=0A= - unless defined(%MIMEFilters);=0A= + unless (%MIMEFilters);=0A= %MIMEFiltersSrc =3D ()=0A= - unless defined(%MIMEFiltersSrc);=0A= + unless (%MIMEFiltersSrc);=0A= =0A= ## - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - = - - -=0A= ## %MIMEFiltersArgs is the associative array for storing any optional=0A= @@ -196,7 +196,7 @@=0A= ## listed for a function if both are applicable.=0A= =0A= %MIMEFiltersArgs =3D ()=0A= - unless defined(%MIMEFiltersArgs);=0A= + unless (%MIMEFiltersArgs);=0A= =0A= ## - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - = - - -=0A= ## %MIMEExcs is the associative array listing which data types=0A= @@ -206,7 +206,7 @@=0A= ## Values =3D> =0A= =0A= %MIMEExcs =3D ()=0A= - unless defined(%MIMEExcs);=0A= + unless (%MIMEExcs);=0A= =0A= ## - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - = - - -=0A= ## %MIMEIncs is the associative array listing which data types=0A= @@ -220,7 +220,7 @@=0A= ## be used to only allow a well-defined set of content-types.=0A= =0A= %MIMEIncs =3D ()=0A= - unless defined(%MIMEIncs);=0A= + unless (%MIMEIncs);=0A= =0A= ## - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - = - - -=0A= ## %MIMECharsetAliases is a mapping of charset names to charset names.=0A= @@ -231,7 +231,7 @@=0A= ## Values =3D> real charset name=0A= ##=0A= %MIMECharsetAliases =3D ()=0A= - unless defined(%MIMECharsetAliases);=0A= + unless (%MIMECharsetAliases);=0A= =0A= = ##-----------------------------------------------------------------------= ----=0A= ## Text entity-related variables=0A= ------=_NextPart_000_0001_01CCD522.AC19AD30--