From owner-cvs-all@FreeBSD.ORG Fri May 4 19:15:30 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AD74C16A401; Fri, 4 May 2007 19:15:30 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 9E90313C45E; Fri, 4 May 2007 19:15:30 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l44JFUjc069304; Fri, 4 May 2007 19:15:30 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l44JFUDI069303; Fri, 4 May 2007 19:15:30 GMT (envelope-from phk) Message-Id: <200705041915.l44JFUDI069303@repoman.freebsd.org> From: Poul-Henning Kamp Date: Fri, 4 May 2007 19:15:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/gem if_gem.c if_gem_pci.c if_gemvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 19:15:30 -0000 phk 2007-05-04 19:15:29 UTC FreeBSD src repository Modified files: sys/dev/gem if_gem.c if_gem_pci.c if_gemvar.h Log: Since if_gem is being touted as one of our more architecturally correct network drivers with respect to busmaster DMA, go over it with at duster to make other aspects of it a role model: Eliminate the pci specific softc, it serves no rational purpose. Use convenience resource allocation/deallocation functions to save code and errorhandling. Switch from bus_space_{read|write}_%u() to bus_{read|write}_%u() functions and forget about tags and handles, the resource will know about those, should they be needed. This also eliminates a number of inconsistently named local variables. Revision Changes Path 1.41 +112 -141 src/sys/dev/gem/if_gem.c 1.22 +27 -52 src/sys/dev/gem/if_gem_pci.c 1.13 +2 -2 src/sys/dev/gem/if_gemvar.h