From nobody Mon Jan 26 16:58:18 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f0F9W5Qryz6QWVF; Mon, 26 Jan 2026 16:58:39 +0000 (UTC) (envelope-from gallatin@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f0F9W4Kq5z3KH8; Mon, 26 Jan 2026 16:58:39 +0000 (UTC) (envelope-from gallatin@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769446719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7RYi7rfizA6Y8zjgdA9cKzA9l5vg355MIwgPR9dn164=; b=FZ3cEH4ZG5I175CpBuZN63l37/iThu9fVCt8tOIu1WRhXenl5u9dT8d6JVR4c6NGkyhUCU GCwjBiKaoTzLx8p4T7JxSnkMajbAvG1W0mMN+gtTBm2qq0fU12x81HRVKyU5gxVzuUQqYh yUeZX1pcrDHzOAoG0h4kciQIMueezI4lIaPpQwqO7t4bgop8zVphsxj6azJSqRz/SYNBDr rjRY4bCK/pTmZZWhV7ZMVIcQeCmx06ffj/WrXmq3uag5+riPRxpVMcLMBQkEZ6cHV3mTHB wQd4QZj3LnvzeRfuH3pZ0t9xUYL6rxm38heAKvFjr5x7pc0g1XD9yEHJMn8QDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769446719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7RYi7rfizA6Y8zjgdA9cKzA9l5vg355MIwgPR9dn164=; b=ZNfrOFhMy+h6azRMcYmViAe0+lxnhcj+Js7cXLeaSaRMgpUGmiG3mJwbDowCIofHCclyv9 ELy1oNHZrE7VLhG7i/9XR2e1aE1lQLnFoD2nV7pt4ioAaPtne7biQW0kBWRjqHxNIaHIiB M4QnR+sRhsnZC/bmoenl2mGFpFZiGKAu6zlMjMaw7H5N21ai7EBIQ3xiprU1XBveS/wo8M WfZdw1V04h7rspDuTFQzbZiZFk0FQ+z965zGnA3654PCT0DqJqB/mp5MZIJhJTv9x+i2N+ 5EFb+Li0PwPYWtm6eZFnrijyppJW83a/96MCzlXhAPKrpjj4Sxy2SkOU9tiEsA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769446719; a=rsa-sha256; cv=none; b=AO5TMz77QBlclWaxwHHytk58pSeI9lXBnGma0SkqOf9tQP3P/s15y8mg8f6ZYlse9qiogI ZcCKGKhmylSGhMjW2ds/XWCRkWvyGjlHULGDj8lrv5AtCs06L15GaFpfq27fmkNihvvoNM CKwzva/WpDou0BFR/7obd9d5z8eCk8eNoNK6Ww+3v6syHiPIUB2hL5GRNrCtzR6K9lOL3i rialcKTCLzhIsz2aaOdxuhO6rJR82s3N95kClQ6l7aH+rlHnWwnz5Uu3Vxfp0c8ZxcWavx fmTRPEcDblaseNciQCLotZGixmEnqjlhC+gvKv61XhCkFzEBeF6unoOoHsAPqg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from fauth-a2-smtp.messagingengine.com (fauth-a2-smtp.messagingengine.com [103.168.172.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gallatin) by smtp.freebsd.org (Postfix) with ESMTPSA id 4f0F9W3HGCz1Cys; Mon, 26 Jan 2026 16:58:39 +0000 (UTC) (envelope-from gallatin@freebsd.org) Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfauth.phl.internal (Postfix) with ESMTP id 9DD16F40068; Mon, 26 Jan 2026 11:58:38 -0500 (EST) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-05.internal (MEProxy); Mon, 26 Jan 2026 11:58:38 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdduheekvdduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpefoggffhffvvefkjghfufgtsegrtderre ertdejnecuhfhrohhmpedfffhrvgifucfirghllhgrthhinhdfuceoghgrlhhlrghtihhn sehfrhgvvggsshgurdhorhhgqeenucggtffrrghtthgvrhhnpeeuhfehtdelgedtgfdutd fhteeuveelvdekjeegkedvgffhteegvdehgefhueeifeenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrghllhgrthhinhdomhgvshhmthhprg huthhhphgvrhhsohhnrghlihhthidqudeffeehledvvdduiedqvdelhedtgedukeegqdhg rghllhgrthhinheppehfrhgvvggsshgurdhorhhgsehfrghsthhmrghilhdrtghomhdpnh gspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepuggvshes fhhrvggvsghsugdrohhrghdprhgtphhtthhopeguvghvqdgtohhmmhhithhsqdhsrhgtqd grlhhlsehfrhgvvggsshgurdhorhhgpdhrtghpthhtohepuggvvhdqtghomhhmihhtshdq shhrtgdqmhgrihhnsehfrhgvvggsshgurdhorhhgpdhrtghpthhtohepshhrtgdqtghomh hmihhtthgvrhhssehfrhgvvggsshgurdhorhhg X-ME-Proxy: Feedback-ID: i41414658:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 80CDB700065; Mon, 26 Jan 2026 11:58:38 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 X-ThreadId: ABUamp0rnb8N Date: Mon, 26 Jan 2026 11:58:18 -0500 From: "Drew Gallatin" To: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Message-Id: In-Reply-To: <86jyx4e3ec.fsf@ltc.des.dev> References: <697757ba.b040.558a1a55@gitrepo.freebsd.org> <86jyx4e3ec.fsf@ltc.des.dev> Subject: Re: git: a11d132f6c62 - main - devstat: Provide 32-bit compatibility Content-Type: multipart/alternative; boundary=87bac4377674430fa19961f36e0e3edd --87bac4377674430fa19961f36e0e3edd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Jan 26, 2026, at 11:37 AM, Dag-Erling Sm=C3=B8rgrav wrote: > "Drew Gallatin" writes: > > In file included from /usr/src/sys/kern/subr_devstat.c:47: > > In file included from /usr/src/sys/compat/freebsd32/freebsd32.h:38: > > /usr/src/sys/sys/user.h:692:16: error: field has incomplete type 'st= ruct kevent' > > 692 | struct kevent knt_event; > > | ^ > > /usr/src/sys/sys/user.h:692:9: note: forward declaration of 'struct = kevent' > > 692 | struct kevent knt_event; >=20 > This is a preexisting bug in which > needs to include but doesn't. It is hidden from most > users by header pollution from the VIMAGE option. Thanks for the quick fix. I'm an oddball b/c I cannot stand VIMAGE (mak= es network stuff incredibly frustrating to debug and adds overhead). > > include GENERIC-NODEBUG > > [...] > > nooptions INVARIANTS > > nooptions INVARIANT_SUPPORT > > nooptions WITNESS > > nooptions WITNESS_SKIPSPIN > > nooptions BUF_TRACKING > > nooptions DEADLKRES > > nooptions FULL_BUF_TRACKING > > nooptions COVERAGE > > nooptions KCOV >=20 > These lines are already included in GENERIC-NODEBUG. Indeed..=20 Thanks again, Drew --87bac4377674430fa19961f36e0e3edd Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable


On Mon, Jan 26, 2026, at 11:37 AM, Dag-Erling Sm=C3=B8= rgrav wrote:
"D= rew Gallatin" <gallatin@freeb= sd.org> writes:
> In file included from /usr/src/sys= /kern/subr_devstat.c:47:
> In file included from /usr/src/s= ys/compat/freebsd32/freebsd32.h:38:
> /usr/src/sys/sys/user= .h:692:16: error: field has incomplete type 'struct kevent'
&g= t;   692 |         str= uct kevent   knt_event;
>    =    |         &nbs= p;           &nbs= p;   ^
> /usr/src/sys/sys/user.h:692:9: note: for= ward declaration of 'struct kevent'
>   692 |&nbs= p;        struct kevent   k= nt_event;

This is a preexisting bug in <sys/= compat/freebsd32/freebsd32.h> which
needs to include <sy= s/event.h> but doesn't.  It is hidden from most
users = by header pollution from the VIMAGE option.

<= /div>
Thanks for the quick fix.  I'm an oddball b/c I cannot st= and VIMAGE (makes network stuff incredibly frustrating to debug and adds= overhead).

> include GENERIC-NODEBUG
> [...]
= > nooptions       INVARIANTS
= > nooptions       INVARIANT_SUPPORT
> nooptions       WITNESS
<= div>> nooptions       WITNESS_SKIPSPIN<= /div>
> nooptions       BUF_TRACKIN= G
> nooptions       DEADLKRES=
> nooptions       FULL_BUF_T= RACKING
> nooptions       COV= ERAGE
> nooptions       KCOV<= /div>

These lines are already included in GENERIC-NOD= EBUG.

Indeed.. 
Thanks again,
Drew

--87bac4377674430fa19961f36e0e3edd--