From owner-svn-ports-head@freebsd.org Tue Mar 16 22:10:22 2021 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 38AA756FC58; Tue, 16 Mar 2021 22:10:22 +0000 (UTC) (envelope-from SRS0=rGmH=IO=FreeBSD.org=otis@ns2.wilbury.net) Received: from ns2.wilbury.net (ns2.wilbury.net [92.60.51.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "svc.wilbury.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F0SCL0Vb1z3m85; Tue, 16 Mar 2021 22:10:21 +0000 (UTC) (envelope-from SRS0=rGmH=IO=FreeBSD.org=otis@ns2.wilbury.net) Received: from [100.127.255.20] (gw-upc.owhome.net [188.167.168.254]) (Authenticated sender: juraj@lutter.sk) by svc.wilbury.net (Postfix) with ESMTPSA id 2350445D0EC; Tue, 16 Mar 2021 23:10:18 +0100 (CET) From: Juraj Lutter Message-Id: <2239997E-E3B6-403F-B36D-4326CDF16EFE@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_F0A0BFCB-D68B-4DF3-A6D8-6D0848EF633D"; protocol="application/pgp-signature"; micalg=pgp-sha256 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: svn commit: r568508 - head/devel/node-gyp Date: Tue, 16 Mar 2021 23:10:16 +0100 In-Reply-To: <20210316211715.pa4w3lrffzxr3ftx@aching.in.mat.cc> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org To: Mathieu Arnold References: <202103152102.12FL2tRP068067@repo.freebsd.org> <20210316211715.pa4w3lrffzxr3ftx@aching.in.mat.cc> X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4F0SCL0Vb1z3m85 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 22:10:22 -0000 --Apple-Mail=_F0A0BFCB-D68B-4DF3-A6D8-6D0848EF633D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 16 Mar 2021, at 22:17, Mathieu Arnold wrote: >=20 > On Mon, Mar 15, 2021 at 09:02:55PM +0000, Juraj Lutter wrote: >> Author: otis >> Date: Mon Mar 15 21:02:55 2021 >> New Revision: 568508 >> URL: https://svnweb.freebsd.org/changeset/ports/568508 >>=20 >> Log: >> Add port: devel/node-gyp: a build frmework for building Node.js = applications. >=20 > A few problems with this, and the next 2 ports added, so putting my > portmgr's hat on. >=20 > We do not add node modules to the ports tree. > We really do not add node modules to the ports tree. >=20 > If an application needs nodes modules to work, then the port for that > application needs to handle the modules installing, and put those in a > private place. >=20 > lib/node_modules is a really aweful place to put this. As a side = note, > if we were to add node modules to the ports tree, which we are not, it > would probably be libdata/node_modules or share/node_modules. >=20 > Please remove those ports. The rationale behind this is: - Upcoming textproc/kibana7 has =E2=80=9Cre2=E2=80=9D node module = bundled, which also contains a re2.node binary module, that (from distribution tarball) can be for = Linux or Darwin. - In order to build re2.node binary component for FreeBSD in poudriere = without need for network access that would otherwise be needed, separate port seemed the = most ellegant way. I value your comment and any hints/advises are welcome. Thanks otis --Apple-Mail=_F0A0BFCB-D68B-4DF3-A6D8-6D0848EF633D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iHUEAREIAB0WIQR9WLqI3W4V0bRHtaAtyIKFszIZVAUCYFEsyAAKCRAtyIKFszIZ VPgFAP43UbcyHAC98g1wbmAwumfUo/ByxxxrvZ058aO59E5UAwD8C813LS+cTDIk 88aj72283NJiIOeGFyA63weDRKRllw4= =3+ty -----END PGP SIGNATURE----- --Apple-Mail=_F0A0BFCB-D68B-4DF3-A6D8-6D0848EF633D--