From owner-svn-src-all@FreeBSD.ORG Sun Oct 27 16:20:52 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A74BA8B5; Sun, 27 Oct 2013 16:20:52 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 964C02F64; Sun, 27 Oct 2013 16:20:52 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r9RGKqwv037352; Sun, 27 Oct 2013 16:20:52 GMT (envelope-from kib@svn.freebsd.org) Received: (from kib@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r9RGKqfb037351; Sun, 27 Oct 2013 16:20:52 GMT (envelope-from kib@svn.freebsd.org) Message-Id: <201310271620.r9RGKqfb037351@svn.freebsd.org> From: Konstantin Belousov Date: Sun, 27 Oct 2013 16:20:52 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r257214 - head/sys/kern X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Oct 2013 16:20:52 -0000 Author: kib Date: Sun Oct 27 16:20:52 2013 New Revision: 257214 URL: http://svnweb.freebsd.org/changeset/base/257214 Log: When reentering kdb, typically due to a bug causing trap or assert in the code executed in the context of debugger, do not be ashamed to inform loudly about the re-entry. Also, print the backtrace before obliterating current stack with longjmp, allowing the operator to see a place which caused the bug. The change should make it less mysterious debugging the ddb itself. Sponsored by: The FreeBSD Foundation MFC after: 1 week Modified: head/sys/kern/subr_kdb.c Modified: head/sys/kern/subr_kdb.c ============================================================================== --- head/sys/kern/subr_kdb.c Sun Oct 27 16:18:48 2013 (r257213) +++ head/sys/kern/subr_kdb.c Sun Oct 27 16:20:52 2013 (r257214) @@ -503,6 +503,8 @@ kdb_reenter(void) if (!kdb_active || kdb_jmpbufp == NULL) return; + printf("KDB: reentering\n"); + kdb_backtrace(); longjmp(kdb_jmpbufp, 1); /* NOTREACHED */ }