Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Jun 2013 02:24:59 +0200
From:      nemysis <nemysis@gmx.ch>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        jpaetzel@FreeBSD.org
Subject:   ports/179796: [PATCH] sysutils/lxtask: Add license, docs, fix NLS, take maintainership
Message-ID:  <20130621002503.1699051A@hub.freebsd.org>
Resent-Message-ID: <201306210030.r5L0U0KT070336@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         179796
>Category:       ports
>Synopsis:       [PATCH] sysutils/lxtask: Add license, docs, fix NLS, take maintainership
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 21 00:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE-p8 amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.1-RELEASE-p8 FreeBSD 9.1-RELEASE-p8 #0: Tue Jun 18 15:25:28 UTC 2013
>Description:

- Take maintainership
- Add license (GPLv2)
- Add docs
- Add DOCS NLS Options
- Fix NLS
- Trim pkg-descr
- Trim pkg-message

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports)

Build log

https://redports.org/buildarchive/20130621001600-27749/

>How-To-Repeat:
>Fix:

--- lxtask-0.1.4_1.patch begins here ---
diff -ruN /usr/ports/sysutils/lxtask/Makefile ./Makefile
--- /usr/ports/sysutils/lxtask/Makefile	2013-06-02 18:58:38.000000000 +0200
+++ ./Makefile	2013-06-21 01:59:57.000000000 +0200
@@ -5,30 +5,47 @@
 PORTVERSION=	0.1.4
 PORTREVISION=	1
 CATEGORIES=	sysutils gnome
-MASTER_SITES=	SF/lxde/LXTask%20%28task%20manager%29/LXTask%20${PORTVERSION}
+MASTER_SITES=	SF/lxde/LXTask%20%28task%20manager%29/LXTask%20${PORTVERSION}/
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	nemysis@gmx.ch
 COMMENT=	Lightweight desktop-independent task manager
 
-USE_GNOME=	gtk20 intlhack
-USE_GMAKE=	yes
+LICENSE=	GPLv2
+
 USES=		iconv
+USE_GNOME=	gtk20 intlhack
 GNU_CONFIGURE=	yes
+USE_GMAKE=	yes
 USE_LDCONFIG=	yes
 
+PORTDOCS=	AUTHORS README TODO
+
+OPTIONS_DEFINE=	DOCS NLS
+OPTIONS_SUB=	yes
+
+NLS_USES=	gettext
+
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MNLS}
-USES+=		gettext
-PLIST_SUB+=	NLS=""
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
-.else
-CONFIGURE_ARGS+=--disable-nls
-PLIST_SUB+=	NLS="@comment "
+.endif
+
+post-patch:
+.if ! ${PORT_OPTIONS:MNLS}
+	@${REINPLACE_CMD} -e 's|po src|src|' \
+		${WRKSRC}/Makefile.in
 .endif
 
 post-install:
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
+.endif
+
+	@${ECHO_CMD}
 	@${CAT} ${PKGMESSAGE}
+	@${ECHO_CMD}
 
 .include <bsd.port.mk>
diff -ruN /usr/ports/sysutils/lxtask/pkg-descr ./pkg-descr
--- /usr/ports/sysutils/lxtask/pkg-descr	2013-06-02 18:58:38.000000000 +0200
+++ ./pkg-descr	2013-06-21 00:57:55.000000000 +0200
@@ -1,3 +1,5 @@
-lxtask is a lightweight desktop-independent task manager.
+LXTask - lightweight and desktop-independent task manager derived from
+xfce4-taskmanager with all dependencies on xfce removed, new features,
+and some improvement of the user interface.
 
 WWW: http://lxde.sourceforge.net/
diff -ruN /usr/ports/sysutils/lxtask/pkg-message ./pkg-message
--- /usr/ports/sysutils/lxtask/pkg-message	2013-06-02 18:58:38.000000000 +0200
+++ ./pkg-message	2013-06-21 02:15:13.000000000 +0200
@@ -1,4 +1,14 @@
-******************************************************
-This ports works only if linprocfs is mounted. Ensure
-that linprocfs is mounted before running. 
-*****************************************************
+################################################################################
+
+This program will attempt to obtain some system information by accessing files
+in linprocfs. You must mount linprocfs filesystem for this to work correctly.
+This can be accomplished by adding the following line to your /etc/fstab file:
+
+# Device                Mountpoint              FStype          Options Dump Pass
+linprocfs               /compat/linux/proc      linprocfs       rw      0       0
+
+and then, as root, executing the command:
+
+mount linprocfs
+
+################################################################################
--- lxtask-0.1.4_1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130621002503.1699051A>