Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Nov 2012 09:44:01 +0000 (UTC)
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r307265 - head/multimedia/xmms
Message-ID:  <201211100944.qAA9i1aM075322@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: danfe
Date: Sat Nov 10 09:44:01 2012
New Revision: 307265
URL: http://svnweb.freebsd.org/changeset/ports/307265

Log:
  Apparently, in some cases (per what I observe here) using empty(...) for
  testing specific PORT_OPTIONS instead of kosher ! breaks the build.  Fix
  this.  While here, move the test below the target.
  
  Approved by:	maintainer
  Feature safe:	yes

Modified:
  head/multimedia/xmms/Makefile

Modified: head/multimedia/xmms/Makefile
==============================================================================
--- head/multimedia/xmms/Makefile	Sat Nov 10 09:41:47 2012	(r307264)
+++ head/multimedia/xmms/Makefile	Sat Nov 10 09:44:01 2012	(r307265)
@@ -111,8 +111,8 @@ EXTRA_PATCHES=	${FILESDIR}/extra-patch-V
 PLIST_SUB+=	SPEC="@comment "
 .endif
 
-.if empty(${PORT_OPTIONS:MSIMD})
 post-extract:
+.if ! ${PORT_OPTIONS:MSIMD}
 	(cd ${WRKSRC}/Input/mpg123 && ${MV} decode_i586.s decode_i586.S && \
 	  cd ${WRKSRC}/Visualization/blur_scope && ${MV} blur_8.s blur_8.S);
 	${REINPLACE_CMD} -e 's:\.s :.S :g' -e 's:\.s$$:.S:g' \
@@ -129,7 +129,7 @@ pre-extract:
 	@${ECHO_MSG} ""
 .endif
 
-.if empty(${PORT_OPTIONS:MRUSXMMS_PATCHES})
+.if ! ${PORT_OPTIONS:MRUSXMMS_PATCHES}
 	@${ECHO_MSG} ""
 	@${ECHO_MSG} "You can enable support for ID3v2 tags and CP1251"
 	@${ECHO_MSG} "encoding by setting the RUSXMMS_PATCHES option."



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201211100944.qAA9i1aM075322>