From owner-cvs-all@FreeBSD.ORG Sat Aug 26 02:32:04 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BD2E16A4DD; Sat, 26 Aug 2006 02:32:04 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.208.78.105]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9056C43D6D; Sat, 26 Aug 2006 02:31:59 +0000 (GMT) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.13.7/8.13.7) with ESMTP id k7Q2VKJQ074576; Fri, 25 Aug 2006 19:31:20 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.13.7/8.13.7/Submit) id k7Q2VKpJ074575; Fri, 25 Aug 2006 19:31:20 -0700 (PDT) (envelope-from sgk) Date: Fri, 25 Aug 2006 19:31:20 -0700 From: Steve Kargl To: Peter Jeremy Message-ID: <20060826023120.GA74468@troutmask.apl.washington.edu> References: <200608240737.k7O7bDMC085424@repoman.freebsd.org> <20060824092002.44b90594@kan.dnsalias.net> <20060824133628.GA54467@gvr.gvr.org> <20060824101606.414e8bf6@kan.dnsalias.net> <20060824205854.GA59856@gvr.gvr.org> <20060824184402.2ee29d79@kan.dnsalias.net> <20060826020854.GD16768@turion.vk2pj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060826020854.GD16768@turion.vk2pj.dyndns.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Guido van Rooij , Alexander Kabaev , cvs-all@freebsd.org Subject: Re: cvs commit: src/contrib/ipfilter HISTORY Makefile bpf_filter.c ip_fil.c ipf.h ipmon.h ipt.h kmem.h mlfk_rule.c opts.h radix.c radix_ipf.h snoop.h src/contrib/ipfilter/BSD Makefile Makefile.ipsend kupgrade src/contrib/ipfilter/iplang iplang_l.l ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Aug 2006 02:32:04 -0000 On Sat, Aug 26, 2006 at 12:08:54PM +1000, Peter Jeremy wrote: > On Thu, 2006-Aug-24 18:44:02 -0400, Alexander Kabaev wrote: > >personally. The mistake you made just shows how important it is to do a > >buildworld _from freshly checked out sources_ after every major vendor > >import. > > I'm not sure how doing this would have prevented the breakage. It > might have allowed Guido to notice the breakage more quickly. It would have caught the first problem, which I reported here http://lists.freebsd.org/pipermail/freebsd-current/2006-August/065175.html. This problem was fixed by kan as noted here http://lists.freebsd.org/pipermail/cvs-src/2006-August/067536.html Notice I reported the problem of Aug 16th. Kan's patch was committed on Aug 17th. > Guido made a mistake, has apologised and has corrected the problem in > less than 6 hours. He only corrected the second problem caused by his commit. > Doing a fresh checkout and a "make universe" > (since "make buildworld" is not always sufficient to catch breakage) > may not have been that much faster. Huh? If Guido had done a "make buildworld" or "make universe" before he committed the source, then the problem would never have existed. -- Steve