From owner-freebsd-net@FreeBSD.ORG  Tue Feb  5 21:02:34 2013
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 7BBBAA94;
 Tue,  5 Feb 2013 21:02:34 +0000 (UTC)
 (envelope-from jfvogel@gmail.com)
Received: from mail-ve0-f178.google.com (mail-ve0-f178.google.com
 [209.85.128.178])
 by mx1.freebsd.org (Postfix) with ESMTP id E735C832;
 Tue,  5 Feb 2013 21:02:33 +0000 (UTC)
Received: by mail-ve0-f178.google.com with SMTP id db10so524488veb.23
 for <multiple recipients>; Tue, 05 Feb 2013 13:02:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:in-reply-to:references:date:message-id
 :subject:from:to:cc:content-type;
 bh=pkkpziCS6MCrE3hTz5S5WRqNvMfdvvDBbPQap8qaqm8=;
 b=hKcC4b2XouVteqzsi7B3g25ZzoZHJihUH2RVH29fSMtE5Tyk2uqAQBsKASH9wwci24
 DsKDH56anBkh9uVPPQF4uTHCjjfllQNs/1iLBo0k054Wgp9b3cLDjLPolk/MAq7xq8sB
 PRwIb6D3gu3xWoTpma20rOoD9tpPGdRNMJ6eMTNT9WF3rpi7Zl82+XokmMLTyzya2Kc9
 OOar4BANa4Y5zsZXhnbo+Q21S2CF62CNCQQ5KjgjS0bpuuc2zudzYNM68P484hFn4P2J
 Yo6hhVoGPN5rCBsqZahs+a4iWTZrzl0T9eOQdAGnGfCeO4ygkm3VATZLcnHSmuoTjk/r
 aKMw==
MIME-Version: 1.0
X-Received: by 10.52.29.109 with SMTP id j13mr26006577vdh.111.1360098147105;
 Tue, 05 Feb 2013 13:02:27 -0800 (PST)
Received: by 10.220.191.132 with HTTP; Tue, 5 Feb 2013 13:02:26 -0800 (PST)
In-Reply-To: <201302051552.04275.jhb@freebsd.org>
References: <D3AA078A-CD19-4228-A019-BE9C985895E2@lakerest.net>
 <201302051411.52495.jhb@freebsd.org>
 <74624C61-0564-420F-9F82-0475488F857C@lakerest.net>
 <201302051552.04275.jhb@freebsd.org>
Date: Tue, 5 Feb 2013 13:02:26 -0800
Message-ID: <CAFOYbcmD==OrmP-b0jwbyX8vYykUE95KJ0hi5mgKjg7WyR1zZQ@mail.gmail.com>
Subject: Re: Driver patch to look at...
From: Jack Vogel <jfvogel@gmail.com>
To: John Baldwin <jhb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: freebsd-net@freebsd.org, Robert Watson <rwatson@freebsd.org>,
 Randall Stewart <rrs@lakerest.net>, Kip Macy <kmacy@freebsd.org>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Feb 2013 21:02:34 -0000

Thanks for being the critical eye John :) And I appreciate the work
Randall, thanks!

Jack


On Tue, Feb 5, 2013 at 12:52 PM, John Baldwin <jhb@freebsd.org> wrote:

> On Tuesday, February 05, 2013 2:30:36 pm Randall Stewart wrote:
> > Ok
> >
> > Here it is one last time (I hope) with the updates ;-)
>
> One more suggestion.  I would make the check in buf_ring_putback_sc() a
> KASSERT() so that in the production case we don't pay for a branch that
> should
> never occur.
>
> --
> John Baldwin
>