From owner-freebsd-questions@FreeBSD.ORG  Sat Dec  2 21:52:23 2006
Return-Path: <owner-freebsd-questions@FreeBSD.ORG>
X-Original-To: freebsd-questions@freebsd.org
Delivered-To: freebsd-questions@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C47A916A407
	for <freebsd-questions@freebsd.org>;
	Sat,  2 Dec 2006 21:52:23 +0000 (UTC)
	(envelope-from fbsd06@mlists.homeunix.com)
Received: from mxout-03.mxes.net (mxout-03.mxes.net [216.86.168.178])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DEFC143CA2
	for <freebsd-questions@freebsd.org>;
	Sat,  2 Dec 2006 21:51:57 +0000 (GMT)
	(envelope-from fbsd06@mlists.homeunix.com)
Received: from gumby.localdomain (unknown [87.81.140.128])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by smtp.mxes.net (Postfix) with ESMTP id 4DF565190F
	for <freebsd-questions@freebsd.org>;
	Sat,  2 Dec 2006 16:52:19 -0500 (EST)
From: RW <fbsd06@mlists.homeunix.com>
To: freebsd-questions@freebsd.org
Date: Sat, 2 Dec 2006 21:52:13 +0000
User-Agent: KMail/1.9.4
References: <20061202074631.S84600@scorpio.seibercom.net>
	<200612021748.18100.fbsd06@mlists.homeunix.com>
	<4571EF71.4000005@u.washington.edu>
In-Reply-To: <4571EF71.4000005@u.washington.edu>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200612022152.14049.fbsd06@mlists.homeunix.com>
Subject: Re: pkgtools.conf error with portmanager
X-BeenThere: freebsd-questions@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: User questions <freebsd-questions.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-questions>, 
	<mailto:freebsd-questions-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-questions>
List-Post: <mailto:freebsd-questions@freebsd.org>
List-Help: <mailto:freebsd-questions-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-questions>, 
	<mailto:freebsd-questions-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Dec 2006 21:52:23 -0000

On Saturday 02 December 2006 21:26, Garrett Cooper wrote:
> RW wrote:

> > My patch file is below.
> >
> > $ cd /usr/ports/sysutils/portmanager/ && cat files/patch-no-ruby-support
> > --- libMGPM/src/MGPMrReadConfigure.c.orig       Sat Dec  2 17:10:45 2006
> > +++ libMGPM/src/MGPMrReadConfigure.c    Sat Dec  2 17:11:37 2006
> > @@ -190,9 +190,7 @@
> >         MGmStrcpy( portupgradeFileName, PREFIXDIR );
> >         MGmStrcat( portupgradeFileName, "/sbin/portupgrade" );
> >
> > -       if( MGrIfFileExist( rubyFileName ) &&
> > -               MGrIfFileExist( pkgtoolsFileName ) &&
> > -               MGrIfFileExist( portupgradeFileName )  )
> > +       if( 0 )
> >         {
> >                 /*
> >                  *  run ruby script
>
> I assume ruby follows the same conventions as many other procedural
> languages ( 0 is false, non-0 is true). 
> 
I've no idea about ruby, the patch is to MGPMrReadConfigure.c 

> If so, why are you preventing
> the lines below if( 0 ) from running in your patch given above? Might as 
> well comment out or delete the following lines because they won't be
> evaluated and run..

True, but that would be more effort, so I might as well not; and keeping it 
simple reduces the chance of a conflict with a future patch.  And it's not as 
if anyone is ever going to permanently integrate this patch into the source 
files.