Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Mar 2010 12:58:38 +0000 (GMT)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Randall Stewart <rrs@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r205104 - in head/sys: dev/xen/netback netinet netinet6
Message-ID:  <alpine.BSF.2.00.1003131257060.51476@fledge.watson.org>
In-Reply-To: <201003122258.o2CMwqDM039077@svn.freebsd.org>
References:  <201003122258.o2CMwqDM039077@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Fri, 12 Mar 2010, Randall Stewart wrote:

>  The proper fix for the delayed SCTP checksum is to
>  have the delayed function take an argument as to the offset
>  to the SCTP header. This allows it to work for V4 and V6.
>  This of course means changing all callers of the function
>  to either pass the header len, if they have it, or create
>  it (ip_hl << 2 or sizeof(ip6_hdr)).

It will become harder to MFC SCTP changes like this in the future, BTW.  It's 
only good (bad) luck that this change doesn't break the KBI depended on by the 
ipdivert module.  If SCTP had been enabled in the module (which it probably 
should be, with options SCTP in GENERIC), then the module would be broken, 
meaning that we couldn't MFC this change as-is.

After MFCing this change, I recommend fixing ipdivert, but also increased 
caution in changing kernel interfaces that may be depended on by modules...

Robert N M Watson
Computer Laboratory
University of Cambridge



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1003131257060.51476>