Date: Sat, 6 Oct 2012 11:31:10 -0400 From: Eitan Adler <eadler@freebsd.org> To: Alberto Villa <avilla@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r305371 - head/audio/audex Message-ID: <CAF6rxgnBk6HCfEWbm1UxuXRNvzi88Bpsh938ys485qvpbCo_6g@mail.gmail.com> In-Reply-To: <CAJp7RHbxiUeE1_tKtOcUYdbpKS7oXcOgz72aceyRCMsE3qUHkg@mail.gmail.com> References: <201210061452.q96EqEUq083915@svn.freebsd.org> <CAJp7RHbxiUeE1_tKtOcUYdbpKS7oXcOgz72aceyRCMsE3qUHkg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6 October 2012 11:24, Alberto Villa <avilla@freebsd.org> wrote:
> On Sat, Oct 6, 2012 at 4:52 PM, Eitan Adler <eadler@freebsd.org> wrote:
>> -.if defined(WITHOUT_NLS)
>> +.if !${PORT_OPTIONS:MNLS}
>
> As far as I know, .if empty(PORT_OPTIONS:MNLS) is the recommended way
> to achieve this (and it's much more readable, by the way).
I think either is okay. If the empty() version is recommended, I can
start to use that for future patches.
--
Eitan Adler
Source & Ports committer
X11, Bugbusting teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnBk6HCfEWbm1UxuXRNvzi88Bpsh938ys485qvpbCo_6g>