From owner-freebsd-ports@FreeBSD.ORG  Mon Aug 23 14:17:00 2004
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6FB7116A4D0
	for <ports@freebsd.org>; Mon, 23 Aug 2004 14:17:00 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6551B43D45; Mon, 23 Aug 2004 14:17:00 +0000 (GMT)
	(envelope-from davidxu@freebsd.org)
Received: from [127.0.0.1] (davidxu@localhost [127.0.0.1])
	i7NEGvls081842;	Mon, 23 Aug 2004 14:16:59 GMT
	(envelope-from davidxu@freebsd.org)
Message-ID: <4129FD61.8030907@freebsd.org>
Date: Mon, 23 Aug 2004 22:21:21 +0800
From: David Xu <davidxu@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.7.1) Gecko/20040730
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Joe Marcus Clarke <marcus@marcuscom.com>
References: <20040823121856.GA65942@iib.unsam.edu.ar>
	<4129E43D.7060901@freebsd.org>
	<1093266183.44764.10.camel@shumai.marcuscom.com>
	<1093266741.44764.12.camel@shumai.marcuscom.com>
In-Reply-To: <1093266741.44764.12.camel@shumai.marcuscom.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: FreeBSD Ports <ports@freebsd.org>
Subject: Re: gnome-terminal sucks
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Aug 2004 14:17:00 -0000

Joe Marcus Clarke wrote:

>On Mon, 2004-08-23 at 09:03, Joe Marcus Clarke wrote:
>  
>
>>On Mon, 2004-08-23 at 08:34, David Xu wrote:
>>    
>>
>>>After I maximized gnome-terminal window,  whenever I drag terminal
>>>window's scrollbar down to scroll forward contents, there is always
>>>some garbage left on screen:
>>>http://people.freebsd.org/~davidxu/screenshot.png
>>>The bug is there from version to version, this really sucks!
>>>      
>>>
>>Wow, that does really suck.  I don't see it here even with your
>>zh_CN.GB2312 locale.  What font are you using?  I tested Bitstream Mono
>>and Courier, and both work okay.
>>
>>http://www.marcuscom.com/downloads/gnome-terminal.png
>>    
>>
>
>David, this looks like it might be
>http://bugzilla.gnome.org/show_bug.cgi?id=146925.  There is a vte patch
>pointer in that bug.  Can you apply that to vte, and let me know if it
>solves your problem?  Thanks.
>
>  
>
Wow, the patch works for me! I pasted it here:

diff -ur vte-0.11.11.orig/src/vte.c vte-0.11.11/src/vte.c
--- vte-0.11.11.orig/src/vte.c	2004-05-02 03:43:01.000000000 -0300
+++ vte-0.11.11/src/vte.c	2004-07-09 21:21:01.000000000 -0300
@@ -13793,7 +13793,7 @@
 	row = MAX(0, (area->y - VTE_PAD_WIDTH) / height);
 	row_stop = MIN(howmany((area->y - VTE_PAD_WIDTH) + area->height,
 			       height),
-		       terminal->row_count - 1);
+		       terminal->row_count);
 	col = MAX(0, (area->x - VTE_PAD_WIDTH) / width);
 	col_stop = MIN(howmany((area->x - VTE_PAD_WIDTH) + area->width,
 			       width),


Thanks,
David Xu