From owner-freebsd-isdn Sun Dec 13 20:48:31 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA24779 for freebsd-isdn-outgoing; Sun, 13 Dec 1998 20:48:31 -0800 (PST) (envelope-from owner-freebsd-isdn@FreeBSD.ORG) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA24774; Sun, 13 Dec 1998 20:48:25 -0800 (PST) (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id UAA12553; Sun, 13 Dec 1998 20:39:51 -0800 (PST) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpdO12550; Mon Dec 14 04:39:41 1998 Date: Sun, 13 Dec 1998 20:39:38 -0800 (PST) From: Julian Elischer To: Poul-Henning Kamp cc: current@FreeBSD.ORG, isdn@FreeBSD.ORG Subject: Re: if_sppp is BROKEN!!! In-Reply-To: <8711.913504842@critter.freebsd.dk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-isdn@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org how about porting the whole shebang to whistle's 'streams' replacement.. we could probably supply the frame relay and ppp packetizer nodes along with the framework and tools... s On Sun, 13 Dec 1998, Poul-Henning Kamp wrote: > > I think I have finally found out what the problem is with the state > machine in the if_sppp implementation. Whoever wrote the implementation > didn't carefully consider the inter-layer calls tls and tlf. > > If one applies a lot of patches like this one: > > case STATE_OPENED: > - (cp->tld)(sp); > sp->rst_counter[cp->protoidx] = 0; > sppp_cp_change_state(cp, sp, STATE_STOPPING); > + (cp->tld)(sp); > goto sta; > break; > > Then things actually start to make sense... > > The problem is that the tld and tlf functions often just call the > pp_up and pp_down routines directly, and therefore most if not all > of the expected up and down events happen in the previous state > as opposed to the next state. > > Flipping it around like I have done above, on the other hand, may > not be a good idea either, since it means we can nest another layer > on the stack and get somewhat confused on the way down. > > It is quite obvious that this will need some more work to sort out, > anybody interested in participating ? > > > -- > Poul-Henning Kamp FreeBSD coreteam member > phk@FreeBSD.ORG "Real hackers run -current on their laptop." > "ttyv0" -- What UNIX calls a $20K state-of-the-art, 3D, hi-res color terminal > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message