Date: Sun, 2 Mar 2003 19:00:34 -0800 (PST) From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/48785: New port: games/dungeoncrawl Message-ID: <200303030300.h2330Yw4044042@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/48785; it has been noted by GNATS.
From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
To: Suleiman Souhlal <refugee@vt.edu>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/48785: New port: games/dungeoncrawl
Date: Mon, 3 Mar 2003 03:52:14 +0100
--XWcu4LpQ=.3dWthV
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Lately Suleiman Souhlal told:
> sed 's/^X//' >dungeoncrawl/Makefile << 'END-of-dungeoncrawl/Makefile'
[...]
> XPLIST_SUB= CRAWLDOCSDIR="${CRAWLDOCSDIR}"
> X
> XCRAWLDOCSDIR?= share/doc/${PORTNAME}
there already exists a variable verry similar: ${DOCSDIR}
> X
> Xpost-patch:
> X @mv ${WRKDIR}/${DISTNAME}/source/makefile.bsd ${WRKDIR}/${DISTNAME}/source/Makefile
use
MAKEFILE= ${WRKSRC}/makefile.bsd
?
> X
> Xpost-install:
> X @${MKDIR} ${PREFIX}/${CRAWLDOCSDIR}
> X.if !defined(NOPORTDOCS)
> X ${INSTALL_MAN} ${WRKDIR}/${DISTNAME}/docs/crawl.txt ${PREFIX}/${CRAWLDOCSDIR}
> X.endif
i think you should move the MKDIR line into the .if !defined; perhaps
even the post-install: target too. otherwise the directory won't be
removed with NOPORTDOCS set (and it will be empty anyways)
cheers
simon
--
/"\ http://corecode.ath.cx/#donate
\ /
\ ASCII Ribbon Campaign
/ \ Against HTML Mail and News
--XWcu4LpQ=.3dWthV
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+YsNer5S+dk6z85oRAuGMAKCXHHlJdqsC3VxwOINV1e0DdUdBQACg8F6X
yxg3ajHJivHixz/2f5y+Bpg=
=ch96
-----END PGP SIGNATURE-----
--XWcu4LpQ=.3dWthV--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200303030300.h2330Yw4044042>