From owner-p4-projects@FreeBSD.ORG Sat Jul 21 23:42:02 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 4C2AB16A41B; Sat, 21 Jul 2007 23:42:02 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1689516A418 for ; Sat, 21 Jul 2007 23:42:02 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 045DA13C428 for ; Sat, 21 Jul 2007 23:42:02 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l6LNg1bQ045784 for ; Sat, 21 Jul 2007 23:42:01 GMT (envelope-from cnst@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l6LNg1w9045779 for perforce@freebsd.org; Sat, 21 Jul 2007 23:42:01 GMT (envelope-from cnst@FreeBSD.org) Date: Sat, 21 Jul 2007 23:42:01 GMT Message-Id: <200707212342.l6LNg1w9045779@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to cnst@FreeBSD.org using -f From: "Constantine A. Murenin" To: Perforce Change Reviews Cc: Subject: PERFORCE change 123874 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2007 23:42:02 -0000 http://perforce.freebsd.org/chv.cgi?CH=123874 Change 123874 by cnst@dale on 2007/07/21 23:41:40 KNF Affected files ... .. //depot/projects/soc2007/cnst-sensors/sys.kern/kern_sysctl.c#3 edit Differences ... ==== //depot/projects/soc2007/cnst-sensors/sys.kern/kern_sysctl.c#3 (text+ko) ==== @@ -156,18 +156,16 @@ int error; error = ENOENT; - if (oidp->oid_number == OID_AUTO) { + if (oidp->oid_number == OID_AUTO) error = EINVAL; - } else { - SLIST_FOREACH(p, oidp->oid_parent, oid_link) { + else + SLIST_FOREACH(p, oidp->oid_parent, oid_link) if (p == oidp) { SLIST_REMOVE(oidp->oid_parent, oidp, sysctl_oid, oid_link); error = 0; break; } - } - } /* * This can happen when a module fails to register and is