From owner-cvs-ports Tue Sep 19 03:09:53 1995 Return-Path: owner-cvs-ports Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA23787 for cvs-ports-outgoing; Tue, 19 Sep 1995 03:09:53 -0700 Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id DAA23768 ; Tue, 19 Sep 1995 03:09:41 -0700 Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.6.12/8.6.9) id DAA01264; Tue, 19 Sep 1995 03:07:52 -0700 Date: Tue, 19 Sep 1995 03:07:52 -0700 Message-Id: <199509191007.DAA01264@silvia.HIP.Berkeley.EDU> To: jmz@cabri.obs-besancon.fr CC: rgrimes@gndrsh.aac.dev.com, CVS-commiters@freefall.freebsd.org, cvs-ports@freefall.freebsd.org In-reply-to: <9509190407.AA26129@cabri.obs-besancon.fr> (message from Jean-Marc Zucconi on Tue, 19 Sep 95 05:07:59 +0100) Subject: Re: cvs commit: ports/utils/ispell/scripts configure From: asami@cs.berkeley.edu (Satoshi Asami) Sender: owner-cvs-ports@FreeBSD.org Precedence: bulk * >> Modified: utils/ispell/scripts configure * >> Log: * >> Compile with -O2 -fno-strength-reduce * This is not always possible. In this case, CFLAGS was hardcoded in a * file (and the flags need to be between quotes). But this is the configure script, there are many ways to pass the CFLAGS picked up from /etc/make.conf. Don't forget the make that's running scripts/configure knows about it already. One way is to modify bsd.port.mk to pass CFLAGS to the configure script in the scripts/ dir as well (not only the one in $WRKSRC/). Probably this should be done anyway, the assymmetry of the invocation mechanisms of $SCRIPTDIR/configure and $WRKSRC/configure has amused me quite a bit in the past. Or we can do something like: ======= Index: Makefile =================================================================== RCS file: /usr/cvs/ports/utils/ispell/Makefile,v retrieving revision 1.9 diff -u -r1.9 Makefile --- 1.9 1995/07/21 13:22:04 +++ Makefile 1995/09/19 10:01:31 @@ -37,6 +37,9 @@ @echo -n .endif +post-configure: + @echo "#define CFLAGS \"${CFLAGS}\"" >> ${WRKSRC}/local.h + british: @echo "Okay, making a british version of ispell...." @${MAKE} ${.MAKEFLAGS} LANG=british all Index: scripts/configure =================================================================== RCS file: /usr/cvs/ports/utils/ispell/scripts/configure,v retrieving revision 1.8 diff -u -r1.8 configure --- 1.8 1995/09/18 23:36:43 +++ configure 1995/09/19 10:00:19 @@ -41,7 +41,6 @@ echo '#define WORDS "/usr/share/dict/words"' >> local.h echo '#undef ELISPDIR' >> local.h echo "#define ELISPDIR \"$PREFIX/share/emacs/site-lisp\"" >> local.h -echo '#define CFLAGS "-O2 -fno-strength-reduce"' >>local.h mv Makefile Makefile.orig sed -e 's/^[ ]*$/\ ======= (Just tested, it works here. :) Satoshi