From owner-freebsd-current@FreeBSD.ORG  Fri Dec  5 13:29:40 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9938B16A4CE
	for <freebsd-current@freebsd.org>;
	Fri,  5 Dec 2003 13:29:40 -0800 (PST)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 673E243FEA
	for <freebsd-current@freebsd.org>;
	Fri,  5 Dec 2003 13:29:38 -0800 (PST)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.10/8.12.10) with ESMTP id hB5LTUV8009420;
	Fri, 5 Dec 2003 22:29:35 +0100 (CET)
	(envelope-from phk@phk.freebsd.dk)
To: Bruce Cran <bruce@cran.org.uk>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Fri, 05 Dec 2003 18:59:49 GMT."
             <20031205185949.GA861@buffy.brucec.backnet> 
Date: Fri, 05 Dec 2003 22:29:30 +0100
Message-ID: <9419.1070659770@critter.freebsd.dk>
cc: freebsd-current@freebsd.org
Subject: Re: panic in devstat_remove_entry 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Dec 2003 21:29:40 -0000

In message <20031205185949.GA861@buffy.brucec.backnet>, Bruce Cran writes:
>
>--r5Pyd7+fXNt84Ff3
>Content-Type: text/plain; charset=us-ascii
>Content-Disposition: inline
>
>I've found a way to panic 5.2-BETA which I can trigger in two ways.

Can you try with this patch ?


Index: geom_event.c
===================================================================
RCS file: /home/ncvs/src/sys/geom/geom_event.c,v
retrieving revision 1.43
diff -u -r1.43 geom_event.c
--- geom_event.c	18 Nov 2003 07:54:12 -0000	1.43
+++ geom_event.c	5 Dec 2003 21:29:03 -0000
@@ -106,8 +106,12 @@
 	KASSERT(error != 0,
 	    ("g_orphan_provider(%p(%s), 0) error must be non-zero\n",
 	     pp, pp->name));
+	
 	pp->error = error;
 	mtx_lock(&g_eventlock);
+	KASSERT(!(pp->flags & G_PF_ORPHAN),
+	    ("g_orphan_provider(%p(%s)), already an orphan", pp, pp->name));
+	pp->flags |= G_PF_ORPHAN;
 	TAILQ_INSERT_TAIL(&g_doorstep, pp, orphan);
 	mtx_unlock(&g_eventlock);
 	wakeup(&g_wait_event);

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.