From nobody Sun Apr 6 22:51:07 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZW6yN3l1hz5s8W2; Sun, 06 Apr 2025 22:51:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZW6yM6Xxpz3KQB; Sun, 06 Apr 2025 22:51:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743979868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Hsb+Ce5v/FM4fH6L3Mh9gN2BG41JvsLG7pjgFVqIE+U=; b=RRAJVorrmeR7GP1eSN7TbjeJvLqdQ8uoUcb+lRWDxJfvn2Xh67IprHCafPlYjSigLgb3ai SDom6C197V0xePUYB4mF/3JNuHs/BnkYEicGq1QMiZZo+/0u7dBgwHdKaEGgDeS7TXOX1M Vgq6lGQT9e6SkHRL0cCQZ3zqdnk3m6jD1w6EsTKk+pvD1OczyCl1tk9yP17PV4Vxx641Te XU4B0byJiPTsNdAsqNK+Ry+FU+6CHAv9zrejxagzIF2O+p+XIv8QCGnaxUGS7AwwsUdW4r XDKtrvaki0/jOijuAhDHxwa10QRZOyUGYtqwX2INwTf6XYFRq5bhUeYiZc7Lhg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1743979868; a=rsa-sha256; cv=none; b=dmTnRnrMt2kdjZClYz5Uy3NAPNbxi7boPJCOn3odVsliA1bj9XqW2L3BHy/iNszc4N1OKt VKrozuRjPms/qxjbPzLF/w6C9HBQEPF7kpxN0TQNHc3jKKoAlAszJ/kvbGdZ0Sjr55bng8 5YY78zrbJWcpUR3BAqgk1ikoTdSs6eDJQhzD11yJwkvBXPDZtcLnIU4op87Ob2Sqdf88YO prbT47ICqqdC+GlHdVUxkPW0T1C4MaASQoY5+7scIt5gNWedn5GTB1e4S37Jay+KhrRfdT ttPat0hwHPIg6X3uCMmwELsHdF7eTHV/Pb+zN1YVJrnNeE4dJk8leWxu1bT9HA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743979868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Hsb+Ce5v/FM4fH6L3Mh9gN2BG41JvsLG7pjgFVqIE+U=; b=Su3jb7P9mlhtH+TiSxLpuuwufgEsFLOLtECNV67IERxGmKa25GRB2baXALTLZjSeiqdieB jP9tG+KT/e66em5viy0mf5CLtHFkhjYbK6aH7mt76j+ZZeMC66G6RCuLxU2wj/hsk812e1 1OEtbCXvdIrALHtJ7l8iwDBR0L5/SXFflFy3qFPusLKq88itf5O78kmrBthiJoivNgVgOr BlKRRcOoKNvPOsUuZ3K4wR3cFC93lvozVZ31I88zcfBUzkCc8VO1f9a0/IX1mFgXziux1k UdEvU+MeKkOWFCuquyMMC31EeIGNAZnOyjJW/RUFeMH6F9aYQCJJ8+n481O2uw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZW6yM3Grvz524; Sun, 06 Apr 2025 22:51:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 536Mp79J076221; Sun, 6 Apr 2025 22:51:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 536Mp7YZ076207; Sun, 6 Apr 2025 22:51:07 GMT (envelope-from git) Date: Sun, 6 Apr 2025 22:51:07 GMT Message-Id: <202504062251.536Mp7YZ076207@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 48fddba63787 - stable/14 - devfs: Return early from sysctl_devname() if no input is given List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 48fddba63787167f7cdc718d39c99efedb0790f4 Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=48fddba63787167f7cdc718d39c99efedb0790f4 commit 48fddba63787167f7cdc718d39c99efedb0790f4 Author: Mark Johnston AuthorDate: 2025-03-20 01:34:10 +0000 Commit: Mark Johnston CommitDate: 2025-04-06 13:54:03 +0000 devfs: Return early from sysctl_devname() if no input is given Otherwise we end up searching for a device using an uninitialized key, tripping up KMSAN. MFC after: 2 weeks (cherry picked from commit 48d6b52add36cc09e7fb1fbec44ab66c0742f320) --- sys/fs/devfs/devfs_devs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/fs/devfs/devfs_devs.c b/sys/fs/devfs/devfs_devs.c index db879efe803a..c6dcd4fc7646 100644 --- a/sys/fs/devfs/devfs_devs.c +++ b/sys/fs/devfs/devfs_devs.c @@ -86,6 +86,9 @@ sysctl_devname(SYSCTL_HANDLER_ARGS) struct cdev_priv *cdp; struct cdev *dev; + if (req->newptr == NULL) + return (EINVAL); + #ifdef COMPAT_FREEBSD11 if (req->newlen == sizeof(ud_compat)) { error = SYSCTL_IN(req, &ud_compat, sizeof(ud_compat));